randr: allow geometry strings to include @n #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When geometry string contain @n, where n is a number from 0..INT_MAX, treat that number as a monitor's assigned number to use. This is similar to how fvwm used to handle these geometry strings with Xinerama, except that the designation of monitor numbers is now derived via a deterministic algorithm. See 'RANDR SUPPORT' in "man fvwm3all"
|
Seems to work OK for me. Testing welcome. |
Centralise looking up a monitor based on its number, so that callers are able to use this.
Switch the hand-rolled code in monitor_resolve_name to use monitor_by_number.
Now that monitor_resolve_name understands how to look up monitors based on a number, simply the code to make use of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When geometry string contain @n, where n is a number from 0..INT_MAX, treat that number as a monitor's assigned number to use.
This is similar to how fvwm used to handle these geometry strings with Xinerama, except that the designation of monitor numbers is now derived via a deterministic algorithm. See 'RANDR SUPPORT' in "man fvwm3all"