Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on macOS 13 in CI #32

Merged
merged 6 commits into from
Jul 6, 2024
Merged

Build on macOS 13 in CI #32

merged 6 commits into from
Jul 6, 2024

Conversation

fwcd
Copy link
Owner

@fwcd fwcd commented Aug 5, 2023

Given that GitHub has phased out macOS 11 runners, we have to migrate to a newer macOS version.

@fwcd fwcd added the ci-cd CI/CD-related label Aug 5, 2023
@fwcd
Copy link
Owner Author

fwcd commented Aug 6, 2023

Looks like Xcode 14.3 broke the build by no longer accepting std::result_of, which also was formally removed in C++20:

In file included from <my mixxx root>/lib/reverb/Reverb.cc:46:
In file included from <my mixxx root>/lib/reverb/basics.h:46:
In file included from <my mixxx root>/src/util/types.h:6:
In file included from <my mixxx root>/src/util/math.h:7:
In file included from <my mixxx root>/src/util/assert.h:3:
In file included from <my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/QtDebug:1:
In file included from <my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qdebug.h:49:
In file included from <my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qtextstream.h:43:
In file included from <my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qiodevice.h:45:
In file included from <my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qobject.h:46:
<my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qobjectdefs.h:535:65: error: no type named 'result_of' in namespace 'std'
    invokeMethod(QObject *context, Func function, typename std::result_of<Func()>::type *ret)
                                                  ~~~~~~~~~~~~~~^~~~~~~~~
<my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qobjectdefs.h:535:74: error: expected ')'
    invokeMethod(QObject *context, Func function, typename std::result_of<Func()>::type *ret)
                                                                         ^
<my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qobjectdefs.h:535:17: note: to match this '('
    invokeMethod(QObject *context, Func function, typename std::result_of<Func()>::type *ret)
                ^
<my vcpkg root>/installed/arm64-osx/include/qt5/QtCore/qobjectdefs.h:540:33: error: use of undeclared identifier 'ret'
                                ret);
                                ^
3 errors generated.
ninja: build stopped: subcommand failed.

Qt 5.14.2 seems to be the first version that patches this (see qt/qtbase@fb6acf0). The upstream vcpkg branch patches this in mixxxdj/vcpkg#70.

Eventually, Mixxx plans to move towards Qt 6 in 2.5, there seem to be some crosscompiling issues, however (see mixxxdj/vcpkg#73) and the CI builds of #33.

fwcd added a commit that referenced this pull request Aug 6, 2023
This should fix the issue in #32 for now, thanks to the patch in
mixxxdj/vcpkg#70.
@fwcd fwcd marked this pull request as ready for review August 15, 2023 18:36
@fwcd fwcd force-pushed the macos-13 branch 3 times, most recently from 2cca40c to f4b94aa Compare November 12, 2023 14:31
@github-actions github-actions bot added the branch update An update of an upstream branch (mixxx, vcpkg) label Nov 12, 2023
@github-actions github-actions bot removed the branch update An update of an upstream branch (mixxx, vcpkg) label Nov 12, 2023
@github-actions github-actions bot added the branch update An update of an upstream branch (mixxx, vcpkg) label Feb 27, 2024
@github-actions github-actions bot removed the branch update An update of an upstream branch (mixxx, vcpkg) label Feb 27, 2024
fwcd and others added 6 commits July 6, 2024 19:26
Hopefully this fixes the issue with `hdiutil` during the creation of the
disk image. Other projects such as OBS use the same workaround for now.

See actions/runner-images#7522
@fwcd fwcd merged commit 423d026 into main Jul 6, 2024
8 checks passed
@fwcd fwcd deleted the macos-13 branch July 6, 2024 20:28
@fwcd
Copy link
Owner Author

fwcd commented Jul 6, 2024

Unfortunately, CI still seems to sporadically fail, likely due to a race condition somewhere between cpack and hdiutil: https://gitlab.kitware.com/cmake/cmake/-/issues/25671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI/CD-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant