Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor isoline creation method #14

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

fwitte
Copy link
Owner

@fwitte fwitte commented Jul 21, 2024

The refactoring makes the isoline creation more simple by allowing somewhat more intelligent iterator isoline property combinations and respective value selections.

On top of that, the PR should introduce

  • custom limits for the iterators for the diagram, which will be derived from p and T limits.
  • a method to generate well spaced isolines based on those limits.

@fwitte fwitte force-pushed the features/refactor_isoline_creation_method branch from f73e48f to 1a5c531 Compare July 21, 2024 13:17
@fwitte fwitte merged commit 1e3cfb1 into master Oct 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant