Refactor/next method #312
Merged
Refactor/next method #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kyvg
commented
Feb 16, 2024
•
kyvg
commented
- перенёс всю логику с отправкой сообщений в battle log в BaseAction,
- сделал единый формат для сообщений, убрав копипасту и бесконечные MagicNext, PhysNext...
- сделал единое форматирование сообщений с уроном
kyvg
force-pushed
the
refactor/next-method
branch
from
f2c9d12
to
9c180f8
Compare
catHD
approved these changes
Feb 17, 2024
| if (error instanceof CastError) { | ||
| this.params.game.recordOrderResult(this.getFailResult(error.reason)); | ||
| } else { | ||
| console.error(error); |
There was a problem hiding this comment.
вот сюда будут сваливаться кучей все error, и потом не найдем откуда
There was a problem hiding this comment.
Так наоборот же теперь легко найти по stack trace будет. Раньше все ошибки летели в logger и там просто выводилось сообщение 'Ошибка парсинга строки магии'. И нигде ты их найти не мог, в консоль они не выводились, т.к. типа "обработанные" были.
Сейчас в logger будут лететь только CastError, а остальные выводиться в консоль вместе со всем stack trace. Можно дополнительно 'Ошибка парсинга строки магии' выводить, если хотим сразу видеть, что что-то сломалось
There was a problem hiding this comment.
Может какой то маркер придумать? Мб в id admin канала слать или что-то в этом роде?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.