Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magic wall exp display #325

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix magic wall exp display #325

merged 1 commit into from
May 28, 2024

Conversation

kyvg
Copy link
Collaborator

@kyvg kyvg commented Apr 11, 2024

No description provided.

Copy link
Collaborator

@catHD catHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Но не увидел правки именно display

@kyvg
Copy link
Collaborator Author

kyvg commented May 28, 2024

Но не увидел правки именно display

reset перенёс до применения стены

@catHD
Copy link
Collaborator

catHD commented May 28, 2024

Да, видел, но как повлияет не понял.

@kyvg
Copy link
Collaborator Author

kyvg commented May 28, 2024

Да, видел, но как повлияет не понял.

Если стена срабатывает, то там происходит throw в preAffect. В таком случае до строки this.reset() просто не доходит

Copy link
Collaborator

@catHD catHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок

@kyvg kyvg merged commit a8a7f69 into master May 28, 2024
3 checks passed
@kyvg kyvg deleted the fix-magic-wall-exp branch May 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants