Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting the optional Curve25519 cipher #1

Open
SEJeff opened this issue Oct 21, 2019 · 2 comments
Open

Consider supporting the optional Curve25519 cipher #1

SEJeff opened this issue Oct 21, 2019 · 2 comments
Labels
enhancement New feature or request waiting Waiting for reply or action

Comments

@SEJeff
Copy link

SEJeff commented Oct 21, 2019

From the FIDO 2 specification ed25519 is Recommended:

Name: Ed25519
Value: 6
Description: Edwards-curve Digital Signature Algorithm on curve 25519
Reference: [RFC8032]
Status: Recommended

It isn't in the supports ciphers in the README or anywhere in the source. Just thought I'd add this here as a "nice to have". Thanks!

@x448
Copy link
Contributor

x448 commented Nov 8, 2019

Do you have a FIDO2 key that supports ed25519? If so, can you provide test data with embedded certs using ed25519? Thanks in advance!

@fxamacker fxamacker added waiting Waiting for reply or action enhancement New feature or request labels Nov 8, 2019
@mitar
Copy link

mitar commented Dec 1, 2023

So Yubikeys now use Ed25519 with -8 code. I tried to register:

const COSEAlgEdDSA = -8
webauthn.RegisterSignatureAlgorithm(COSEAlgEdDSA, x509.PureEd25519, x509.Ed25519, 0)

but it does not work. It seems the rest of the code does not support it (for example, assumes there is always a hash involved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting Waiting for reply or action
Projects
None yet
Development

No branches or pull requests

4 participants