Bamboo sdk base api class #97

Ashutosh619-sudo · 2023-12-11T10:23:00Z

No description provided.

github-actions · 2023-12-11T10:24:56Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.862s ⏱️

codecov · 2023-12-11T10:26:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3812a71) 94.88% compared to head (6788d58) 94.47%.
Report is 5 commits behind head on master.

❗ Current head 6788d58 differs from pull request most recent head 5867d4b. Consider uploading reports for the commit 5867d4b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   94.88%   94.47%   -0.42%     
==========================================
  Files          29       30       +1     
  Lines         958     1031      +73     
==========================================
+ Hits          909      974      +65     
- Misses         49       57       +8

see 4 files with indirect coverage changes

github-actions · 2023-12-11T10:35:03Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.259s ⏱️

github-actions · 2023-12-11T12:05:18Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.741s ⏱️

NileshPant1999 · 2023-12-11T14:23:50Z

bamboosdk/__init__.py

@Ashutosh619-sudo we can create a new folders called connectors
and moved this inside that folder and name it bamboohr

this is fine for now, connectors sounds very generic. We'll just assume we've kept the SDK folder inside API, that's it.

NileshPant1999 · 2023-12-11T14:27:11Z

bamboosdk/exceptions.py

+"""
+
+
+class BambooHrSDKError(Exception):


@Ashutosh619-sudo make sure this contains all the errors

ashwin1111 · 2023-12-11T14:25:01Z

bamboosdk/api/api_base.py

+
+        headers = {
+            "content-type": "application/json",
+            "authorization": f"Basic {self.__encode_username_password()}"


instead of encoding every time, let's do it in line 63 so that it's done only once per SDK initialise

ashwin1111 · 2023-12-11T14:25:42Z

bamboosdk/api/api_base.py

+            "authorization": f"Basic {self.__encode_username_password()}"
+        }   
+
+        payload = { "fields": ["displayName", "firstName", "lastName", "department", "workEmail", "supervisorEmail", "status"] }


if this is common for every API placing here is fine, else move this to resource class

ashwin1111 · 2023-12-11T14:26:48Z

bamboosdk/api/api_base.py

+        if response.status_code == 403:
+            error_msg = json.loads(response.text)
+            raise NoPrivilegeError('Forbidden, the user has insufficient privilege', error_msg)
+
+        if response.status_code == 404:
+            error_msg = json.loads(response.text)
+            raise NotFoundItemError('Not found item with ID', error_msg)
+
+        if response.status_code == 401:
+            error_msg = 'The api token is invalid'
+            raise InvalidTokenError('Invalid token, try to refresh it', error_msg)


checkout docs once and see if these status codes are expected, also in the end add raise 1 exception to handle status codes that are not handled above, 5xx for example

i have checked the docs these are the errors there

NileshPant1999 · 2023-12-11T14:28:37Z

bamboosdk/api/api_base.py

+            raise InvalidTokenError('Invalid token, try to refresh it', error_msg)
+
+
+    def __encode_username_password(self):


why are we encoding and decoding it again

the method b64encode converts the string to base64 byte code which doesn't work when sending in the header and the encoding it done on the this 'byte' its only making that to base64 string.

ashwin1111 · 2023-12-11T14:34:18Z

bamboosdk/api/api_base.py

+        self.__api_token = None
+        self.__sub_domain = None
+
+    def _post_request(self, module_api_path):


we'll need a new func for generator too

github-actions · 2023-12-12T08:56:50Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.472s ⏱️

ashwin1111 · 2023-12-12T15:20:52Z

bamboosdk/api/api_base.py

@@ -47,6 +44,10 @@ def _post_request(self, module_api_path):
            error_msg = 'The api token is invalid'
            raise InvalidTokenError('Invalid token, try to refresh it', error_msg)

+        else:
+            error_msg = 'Something went wrong'
+            raise Exception('Something went wrong')


send response.text to the exception, also create 1 exception, something like BambooHRSDKError() instead of generic one

github-actions · 2023-12-13T06:49:25Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.602s ⏱️

github-actions · 2023-12-20T08:18:09Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.773s ⏱️

github-actions · 2023-12-20T11:39:31Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.785s ⏱️

* class to sync employees from bamboo hr * bug fix * minor changes * comment resolved * minor changes * Bamboo sdk class (#99) * bamboo sdk class * comment resolved * Webhook create and delete API (#108) * webhook api added * indentation fixed * indentaion fixed * minor fix * Fields get API (#109) * Fields get API * added timeoff instead of fields and tested

github-actions · 2023-12-20T12:05:09Z

Tests	Skipped	Failures	Errors	Time
45	1 💤	0 ❌	0 🔥	2.588s ⏱️

bambbo sdk base api class

e7dfcb3

Ashutosh619-sudo temporarily deployed to CI Environment December 11, 2023 10:23 — with GitHub Actions Inactive

Ashutosh619-sudo requested a review from ashwin1111 December 11, 2023 10:25

minor change

0e63fc6

Ashutosh619-sudo temporarily deployed to CI Environment December 11, 2023 10:33 — with GitHub Actions Inactive

minor changes

b5b5943

Ashutosh619-sudo temporarily deployed to CI Environment December 11, 2023 12:03 — with GitHub Actions Inactive

NileshPant1999 reviewed Dec 11, 2023

View reviewed changes

bamboosdk/exceptions.py

"""

class BambooHrSDKError(Exception):

Copy link

Collaborator

NileshPant1999 Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashutosh619-sudo make sure this contains all the errors

ashwin1111 reviewed Dec 11, 2023

View reviewed changes

NileshPant1999 reviewed Dec 11, 2023

View reviewed changes

ashwin1111 reviewed Dec 11, 2023

View reviewed changes

comment resolve

e2e45dd

Ashutosh619-sudo temporarily deployed to CI Environment December 12, 2023 08:55 — with GitHub Actions Inactive

ashwin1111 approved these changes Dec 12, 2023

View reviewed changes

resolved comments

0427fac

Ashutosh619-sudo temporarily deployed to CI Environment December 13, 2023 06:47 — with GitHub Actions Inactive

added new methods

a9b6ebd

Ashutosh619-sudo temporarily deployed to CI Environment December 20, 2023 08:16 — with GitHub Actions Inactive

Ashutosh619-sudo requested a review from ashwin1111 December 20, 2023 08:45

ashwin1111 approved these changes Dec 20, 2023

View reviewed changes

added 201 status code

6788d58

Ashutosh619-sudo temporarily deployed to CI Environment December 20, 2023 11:37 — with GitHub Actions Inactive

Ashutosh619-sudo temporarily deployed to CI Environment December 20, 2023 12:03 — with GitHub Actions Inactive

Ashutosh619-sudo merged commit 6fd47e9 into master Dec 20, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bamboo sdk base api class #97

Bamboo sdk base api class #97

Ashutosh619-sudo commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

codecov bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

NileshPant1999 Dec 11, 2023

ashwin1111 Dec 11, 2023

NileshPant1999 Dec 11, 2023

ashwin1111 Dec 11, 2023

ashwin1111 Dec 11, 2023

ashwin1111 Dec 11, 2023

Ashutosh619-sudo Dec 12, 2023 •

edited

Loading

NileshPant1999 Dec 11, 2023 •

edited

Loading

Ashutosh619-sudo Dec 12, 2023

ashwin1111 Dec 11, 2023

github-actions bot commented Dec 12, 2023

ashwin1111 Dec 12, 2023

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

		raise InvalidTokenError('Invalid token, try to refresh it', error_msg)


		def __encode_username_password(self):

Bamboo sdk base api class #97

Bamboo sdk base api class #97

Conversation

Ashutosh619-sudo commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

codecov bot commented Dec 11, 2023 • edited Loading

Codecov Report

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ashutosh619-sudo Dec 12, 2023 • edited Loading

Choose a reason for hiding this comment

NileshPant1999 Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

codecov bot commented Dec 11, 2023 •

edited

Loading

Ashutosh619-sudo Dec 12, 2023 •

edited

Loading

NileshPant1999 Dec 11, 2023 •

edited

Loading