class to sync employees from bamboo hr #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bamboo_sdk_base #98 +/- ##
===================================================
+ Coverage 94.47% 94.88% +0.41%
===================================================
Files 30 29 -1
Lines 1031 958 -73
===================================================
- Hits 974 909 -65
+ Misses 57 49 -8 |
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
|
NileshPant1999
approved these changes
Dec 11, 2023
ashwin1111
reviewed
Dec 11, 2023
bamboosdk/api/employee.py
Outdated
|
|
||
| GET_EMPLOYEE_REPORT = '/v1/reports/custom?format=JSON&onlyCurrent=false' | ||
|
|
||
| def sync_employees(self): |
There was a problem hiding this comment.
is this API paginated? added 1 more question to slack, will approve after discussion
ashwin1111
reviewed
Dec 11, 2023
bamboosdk/api/employee.py
Outdated
|
|
||
| GET_EMPLOYEE_REPORT = '/v1/reports/custom?format=JSON&onlyCurrent=false' | ||
|
|
||
| def sync_employees(self): |
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
|
ashwin1111
approved these changes
Dec 12, 2023
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Dec 20, 2023
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Ashutosh619-sudo
added a commit
that referenced
this pull request
Dec 20, 2023
* bambbo sdk base api class * minor change * minor changes * comment resolve * resolved comments * added new methods * added 201 status code * class to sync employees from bamboo hr (#98) * class to sync employees from bamboo hr * bug fix * minor changes * comment resolved * minor changes * Bamboo sdk class (#99) * bamboo sdk class * comment resolved * Webhook create and delete API (#108) * webhook api added * indentation fixed * indentaion fixed * minor fix * Fields get API (#109) * Fields get API * added timeoff instead of fields and tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.