-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bamboo sdk class #99
Merged
Merged
Bamboo sdk class #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
December 11, 2023 12:08 — with
GitHub Actions
Inactive
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bamboo_sdk_employee #99 +/- ##
====================================================
Coverage 94.88% 94.88%
====================================================
Files 29 29
Lines 958 958
====================================================
Hits 909 909
Misses 49 49 |
ashwin1111
approved these changes
Dec 11, 2023
bamboosdk/bamboohrsdk.py
Outdated
|
||
class BambooHrSDK: | ||
|
||
def __init__(self, api_token, sub_domain): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add type, api_token: str, sub_domain: str. Add docstrings too
Ashutosh619-sudo
temporarily deployed
to
CI Environment
December 12, 2023 09:26 — with
GitHub Actions
Inactive
|
NileshPant1999
approved these changes
Dec 12, 2023
Ashutosh619-sudo
temporarily deployed
to
CI Environment
December 13, 2023 09:33 — with
GitHub Actions
Inactive
|
Ashutosh619-sudo
temporarily deployed
to
CI Environment
December 20, 2023 08:23 — with
GitHub Actions
Inactive
|
ashwin1111
approved these changes
Dec 20, 2023
Ashutosh619-sudo
temporarily deployed
to
CI Environment
December 20, 2023 11:39 — with
GitHub Actions
Inactive
|
* webhook api added * indentation fixed * indentaion fixed * minor fix * Fields get API (#109) * Fields get API * added timeoff instead of fields and tested
Ashutosh619-sudo
temporarily deployed
to
CI Environment
December 20, 2023 11:57 — with
GitHub Actions
Inactive
|
Ashutosh619-sudo
added a commit
that referenced
this pull request
Dec 20, 2023
* class to sync employees from bamboo hr * bug fix * minor changes * comment resolved * minor changes * Bamboo sdk class (#99) * bamboo sdk class * comment resolved * Webhook create and delete API (#108) * webhook api added * indentation fixed * indentaion fixed * minor fix * Fields get API (#109) * Fields get API * added timeoff instead of fields and tested
Ashutosh619-sudo
added a commit
that referenced
this pull request
Dec 20, 2023
* bambbo sdk base api class * minor change * minor changes * comment resolve * resolved comments * added new methods * added 201 status code * class to sync employees from bamboo hr (#98) * class to sync employees from bamboo hr * bug fix * minor changes * comment resolved * minor changes * Bamboo sdk class (#99) * bamboo sdk class * comment resolved * Webhook create and delete API (#108) * webhook api added * indentation fixed * indentaion fixed * minor fix * Fields get API (#109) * Fields get API * added timeoff instead of fields and tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.