fix: correction in card filters logic (#2818)

fylein · Mar 11, 2024 · 2c17cea · 2c17cea
1 parent 60ba154
commit 2c17cea
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/app/core/services/platform/v1/shared/expenses.service.ts b/src/app/core/services/platform/v1/shared/expenses.service.ts
@@ -200,11 +200,8 @@ export class ExpensesService {
   ): Record<string, string | string[] | boolean> {
     const newQueryParamsCopy = cloneDeep(newQueryParams);
     if (filters.cardNumbers?.length > 0) {
-      let cardNumberString = '';
-      cardNumberString = filters.cardNumbers.join(',');
-      cardNumberString = cardNumberString.slice(0, cardNumberString.length);
-      newQueryParamsCopy['matched_corporate_card_transactions->0->corporate_card_number'] =
-        'in.(' + cardNumberString + ')';
+      const cardNumberString = filters.cardNumbers.map((cardNumber) => `"${cardNumber}"`).join(',');
+      newQueryParamsCopy['matched_corporate_card_transactions->0->corporate_card_number'] = `in.(${cardNumberString})`;
     }
 
     return newQueryParamsCopy;