Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bring back older view team report page and rename the new page as vie… #2605

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

arjunaj5
Copy link
Contributor

@arjunaj5 arjunaj5 commented Nov 23, 2023

…w-team-report-v2
https://app.clickup.com/t/86cu0418a

Description

🤖[deprecated] Generated by Copilot at b1b94e7

This pull request adds a new feature for fetching report expenses by approvers, introduces new components for viewing reports with more details and options, and refactors the existing components and tests to use the Expense model instead of the Expense model. It also updates the templates to use different custom components and Ionic components for rendering the report data. The affected files are report.service.ts, my-view-report.module.ts, view-team-report.module.ts, view-team-report.page.spec.ts, view-team-report.page.ts, view-team-report-v2.page.html, and view-team-report.page.html.

🤖[deprecated] Generated by Copilot at b1b94e7

The team wanted to enhance the report page
So they made some changes that were quite sage
They used app-expense-card and etxn
And added ViewTeamReportPageV2 for the next gen
They also refactored the code and tests at each stage

Walkthrough

🤖[deprecated] Generated by Copilot at b1b94e7

  • Add new components and methods to display report details and actions for own and team reports (link, link, link, link, link)
  • Import and use the Expense model from the core/models/expense.model file to represent the expense data in the report service and the view-team-report feature (link, link, link)
  • Add a new method to the report service to get the expenses for a given report id and org user id, using the /erpts/:id/etxns endpoint (link)
  • Replace the expensesService and the expense model with the reportService and the etxn model in the view-team-report feature, and update the observables, properties, and methods accordingly (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Replace the app-expense-card-v2 component with the app-expense-card component in the view-team-report.page.html file, and update the input bindings and event handlers (link)
  • Add the ngOnInit method to the ViewTeamReportPage component and implement the OnInit interface (link, link, link)
  • Add the getVendorName and getShowViolation methods to the ViewTeamReportPage component to return the vendor name and the policy violation flag for a given expense (link)
  • Add unit tests for the getVendorName and getShowViolation methods of the ViewTeamReportPage component (link, link)

Clickup

Please add link here

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

@github-actions github-actions bot added the size/XL Extra Large PR label Nov 23, 2023
Copy link

Unit Test Coverage % values
Statements 96.93% ( 18194 / 18769 )
Branches 95.03% ( 9236 / 9719 )
Functions 95.95% ( 5627 / 5864 )
Lines 96.97% ( 17320 / 17861 )

@arjunaj5 arjunaj5 requested a review from jayfyle November 30, 2023 07:09
@arjunaj5 arjunaj5 merged commit b15c861 into Fyle-86ctzyc2k-2 Nov 30, 2023
8 checks passed
arjunaj5 added a commit that referenced this pull request Nov 30, 2023
* Bring back older my view report page and rename the new page as my-view-report-v2

* Bring back older view team report page and rename the new page as view-team-report-v2 (#2605)
arjunaj5 added a commit that referenced this pull request Nov 30, 2023
…ew FyViewReportInfoComponent as FyViewReportInfoComponentV2 (#2600)

* Bring back the older FyViewReportInfoComponent and rename the new FyViewReportInfoComponent as FyViewReportInfoComponentV2

* fix failing tests

* feat: Bring back the older my-view-report-page (#2604)

* Bring back older my view report page and rename the new page as my-view-report-v2

* Bring back older view team report page and rename the new page as view-team-report-v2 (#2605)
arjunaj5 added a commit that referenced this pull request Nov 30, 2023
* Remove DRAFT_INQUIRY state for expenses and reports

* fix failing tests;

* feat: Bring back the older FyViewReportInfoComponent and rename the new FyViewReportInfoComponent as FyViewReportInfoComponentV2 (#2600)

* Bring back the older FyViewReportInfoComponent and rename the new FyViewReportInfoComponent as FyViewReportInfoComponentV2

* fix failing tests

* feat: Bring back the older my-view-report-page (#2604)

* Bring back older my view report page and rename the new page as my-view-report-v2

* Bring back older view team report page and rename the new page as view-team-report-v2 (#2605)
arjunaj5 added a commit that referenced this pull request Nov 30, 2023
* Fix failing test cases

* fix other failing tests

* remove unwanted imports

* feat: Demove DRAFT_INQUIRY for expenses and reports (#2580)

* Remove DRAFT_INQUIRY state for expenses and reports

* fix failing tests;

* feat: Bring back the older FyViewReportInfoComponent and rename the new FyViewReportInfoComponent as FyViewReportInfoComponentV2 (#2600)

* Bring back the older FyViewReportInfoComponent and rename the new FyViewReportInfoComponent as FyViewReportInfoComponentV2

* fix failing tests

* feat: Bring back the older my-view-report-page (#2604)

* Bring back older my view report page and rename the new page as my-view-report-v2

* Bring back older view team report page and rename the new page as view-team-report-v2 (#2605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Extra Large PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants