fix: Added fix for cost center not getting assigned upon non-manual selection #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmkarJ13
approved these changes
Nov 29, 2023
OmkarJ13
added a commit
that referenced
this pull request
Nov 29, 2023
…election (#2606) * Added fix for cost center not getting assigned upon non-manual selection * Fixed tests --------- Co-authored-by: julias0 <aiyush.dhar@fyle.in> Co-authored-by: Omkar Joshi <65808188+OmkarJ13@users.noreply.github.com> Co-authored-by: OmkarJ13 <oajoshi13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at 54abe57
Fixed a bug in the merge expense feature where the cost center field was not showing the correct value. Changed the
getCostCentermethod to usetx_cost_center_idinstead oftx_cost_center_nameinmerge-expense.page.ts.🤖[deprecated] Generated by Copilot at 54abe57
Walkthrough
🤖[deprecated] Generated by Copilot at 54abe57
tx_cost_center_idproperty instead of thetx_cost_center_nameproperty to match the cost center options data (link)Clickup
Please add link here
Code Coverage
https://app.clickup.com/t/86ctzabjd