feat: Added Condition for restricting pending txns #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
…to Fyle-86cup7bft-2
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
|
PR description must contain a link to a clickup |
Julias0
reviewed
Feb 28, 2024
| @@ -19,6 +19,11 @@ import { DateService } from '../../../date.service'; | |||
| export class ExpensesService { | |||
| constructor(private dateService: DateService) {} | |||
|
|
|||
| //TODO : ADD CONDITION BASED ON ORG SETTING | |||
| restrictPendingTransactionsEnabled(): boolean { | |||
| return false; | |||
There was a problem hiding this comment.
Lets not merge these PRs till we get the org settings
Julias0
reviewed
Feb 29, 2024
| @@ -27,6 +32,15 @@ export class ExpensesService { | |||
| return typeof expense.policy_amount === 'number' && expense.policy_amount < 0.0001; | |||
| } | |||
|
|
|||
| isExpenseInPendingState(expense: Expense): boolean { | |||
There was a problem hiding this comment.
doesExpenseHavePendingCardTransaction
Julias0
approved these changes
Feb 29, 2024
…to Fyle-86cup7bft-2
|
Julias0
reviewed
Mar 13, 2024
| @@ -61,13 +61,6 @@ | |||
| > | |||
| </app-expense-card> | |||
| </div> | |||
|
|
|||
| <div class="create-new-report--add-more-container" (click)="closeEvent()"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Change for toast message and dialog in my expenses list v2
Remove add more expenses from create new report as it is not working from day 0, refer this thread for discussion around this : https://fylein.slack.com/archives/C017C400V37/p1709031202418129
Clickup
https://app.clickup.com/t/86cuqqvvp
UI Preview
https://www.loom.com/share/0139577e6f7d4b308d8b2bafd5473e9e?sid=f132021b-eb38-4b11-b48a-af41f976d7d0