feat: popover confirmation once commute is updated from form #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julias0
reviewed
Mar 13, 2024
| const sizeLimitExceededPopover = await this.popoverController.create({ | ||
| component: PopupAlertComponent, | ||
| componentProps: { | ||
| title: 'Commute Updated!', |
There was a problem hiding this comment.
Can we avoid the !
Check content with Kamalini
There was a problem hiding this comment.
removing this for now! will add if product confirms that it should remain here.
Julias0
approved these changes
Mar 13, 2024
* fix: mandatory as per txnFields * for round trip disabling * fix: distance can be zero and fix for commute deduction mandatory message (#2826) * fix: distance can be zero and fix for commute deduction mandatory message * minor
…ile-app into add-edit-mileage-changes-2
suyashpatil78
added a commit
that referenced
this pull request
Mar 14, 2024
* feat: fy-select-commute-details modal as shared component * minor * minor * feat: fy-select-commute-details business logic * minor * minor * minor * feat: refractoring in my-profile page * minor * feat: tasks added for showing Add Commute Details * minor * minor * fix: minor * major changes * this commit has switchMap changes * remove consoles * some refractoring and declarations * pr comments part 1 * expenseId as getter * gap removed * feat: popover confirmation once commute is updated from form (#2820) * feat: popover confirmation once commute is updated from form * fix: mandatory as per txnFields (#2823) * fix: mandatory as per txnFields * for round trip disabling * fix: distance can be zero and fix for commute deduction mandatory message (#2826) * fix: distance can be zero and fix for commute deduction mandatory message * minor * minor
suyashpatil78
added a commit
that referenced
this pull request
Mar 19, 2024
) * feat: fy-select-commute-details modal as shared component (#2795) * feat: fy-select-commute-details modal as shared component * minor * minor * feat: fy-select-commute-details business logic (#2799) * feat: fy-select-commute-details business logic * minor * minor * minor * feat: refractoring in my-profile page (#2800) * feat: refractoring in my-profile page * minor * feat: tasks added for showing Add Commute Details (#2801) * feat: tasks added for showing Add Commute Details * minor * minor * pr comment * fixing flaky test * feat: add-edit-mileage changes for commute-details (#2807) * feat: fy-select-commute-details modal as shared component * minor * minor * feat: fy-select-commute-details business logic * minor * minor * minor * feat: refractoring in my-profile page * minor * feat: tasks added for showing Add Commute Details * minor * minor * fix: minor * major changes * this commit has switchMap changes * remove consoles * some refractoring and declarations * pr comments part 1 * expenseId as getter * gap removed * feat: popover confirmation once commute is updated from form (#2820) * feat: popover confirmation once commute is updated from form * fix: mandatory as per txnFields (#2823) * fix: mandatory as per txnFields * for round trip disabling * fix: distance can be zero and fix for commute deduction mandatory message (#2826) * fix: distance can be zero and fix for commute deduction mandatory message * minor * minor * feat: commute deduction in view mileage (#2828) * removed false from my-profile to make commute visible * adjusted height for some devices * fix: disable manual entry in fy-select-commute-details and show toast message if error occurs (#2830) * fix: disable manual entry in fy-select-commute-details * fix: scan failed fix * test: test for ionViewWillEnter method in mileage page (#2831) * test: fixing failing tests in mileage page - Part 2 (#2832) * test: test for ionViewWillEnter method in mileage page * test: fixing failing tests in mileage page * removed foucs * test: fixing route-selector component tests - Part 3 (#2833) * test: fixing route-selector component tests * removed foucs * test: added test for newly added methods (#2834) * minor * pr comments * fix: QA fixes for commute deduction (#2835) * fix: header fix for commute details * minor * QA fixes * minor * tests added * minor correction in modal opening logic * feat: added trackers for commute deduction (#2836) * feat: added trackers for commute deduction * minor * removed console log * minor fixes * fixing coverage
suyashpatil78
added a commit
that referenced
this pull request
Mar 19, 2024
) * feat: fy-select-commute-details modal as shared component (#2795) * feat: fy-select-commute-details modal as shared component * minor * minor * feat: fy-select-commute-details business logic (#2799) * feat: fy-select-commute-details business logic * minor * minor * minor * feat: refractoring in my-profile page (#2800) * feat: refractoring in my-profile page * minor * feat: tasks added for showing Add Commute Details (#2801) * feat: tasks added for showing Add Commute Details * minor * minor * pr comment * fixing flaky test * feat: add-edit-mileage changes for commute-details (#2807) * feat: fy-select-commute-details modal as shared component * minor * minor * feat: fy-select-commute-details business logic * minor * minor * minor * feat: refractoring in my-profile page * minor * feat: tasks added for showing Add Commute Details * minor * minor * fix: minor * major changes * this commit has switchMap changes * remove consoles * some refractoring and declarations * pr comments part 1 * expenseId as getter * gap removed * feat: popover confirmation once commute is updated from form (#2820) * feat: popover confirmation once commute is updated from form * fix: mandatory as per txnFields (#2823) * fix: mandatory as per txnFields * for round trip disabling * fix: distance can be zero and fix for commute deduction mandatory message (#2826) * fix: distance can be zero and fix for commute deduction mandatory message * minor * minor * feat: commute deduction in view mileage (#2828) * removed false from my-profile to make commute visible * adjusted height for some devices * fix: disable manual entry in fy-select-commute-details and show toast message if error occurs (#2830) * fix: disable manual entry in fy-select-commute-details * fix: scan failed fix * test: test for ionViewWillEnter method in mileage page (#2831) * test: fixing failing tests in mileage page - Part 2 (#2832) * test: test for ionViewWillEnter method in mileage page * test: fixing failing tests in mileage page * removed foucs * test: fixing route-selector component tests - Part 3 (#2833) * test: fixing route-selector component tests * removed foucs * test: added test for newly added methods (#2834) * minor * pr comments * fix: QA fixes for commute deduction (#2835) * fix: header fix for commute details * minor * QA fixes * minor * tests added * minor correction in modal opening logic * feat: added trackers for commute deduction (#2836) * feat: added trackers for commute deduction * minor * removed console log * minor fixes * fixing coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
copilot:summary
copilot:poem
Walkthrough
copilot:walkthrough
Clickup
app.clickup.com
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes