test: fix failing tests across the app

src/app/app.component.ts

@@ -24,6 +24,7 @@ import { BackButtonActionPriority } from './core/models/back-button-action-prior
 import { BackButtonService } from './core/services/back-button.service';
 import { TextZoom } from '@capacitor/text-zoom';
 import { GmapsService } from './core/services/gmaps.service';
+import { SpenderOnboardingService } from './core/services/spender-onboarding.service';
 
 @Component({
   selector: 'app-root',
@@ -68,7 +69,8 @@ export class AppComponent implements OnInit {
     private loginInfoService: LoginInfoService,
     private navController: NavController,
     private backButtonService: BackButtonService,
-    private gmapsService: GmapsService
+    private gmapsService: GmapsService,
+    private spenderOnboardingService: SpenderOnboardingService
   ) {
     this.initializeApp();
     this.registerBackButtonAction();
@@ -192,6 +194,14 @@ export class AppComponent implements OnInit {
       }, 500);
     });
 
+    this.spenderOnboardingService.setOnboardingStatusAsComplete().subscribe(() => {
+      if (this.isOnline) {
+        this.sidemenuRef.showSideMenuOnline();
+      } else {
+        this.sidemenuRef.showSideMenuOffline();
+      }
+    });
+
     this.userEventService.onLogout(() => {
       this.trackingService.onSignOut();
       this.freshChatService.destroy();

src/app/auth/switch-org/switch-org.page.spec.ts

@@ -118,7 +118,7 @@ describe('SwitchOrgPage', () => {
     const deepLinkServiceSpy = jasmine.createSpyObj('DeepLinkService', ['getExpenseRoute']);
     const ldSpy = jasmine.createSpyObj('LaunchDarklyService', ['initializeUser']);
     const orgSettingsServiceSpy = jasmine.createSpyObj('OrgSettingsService', ['get']);
-    const spenderOnboardingServiceSpy = jasmine.createSpyObj('SpenderOnboardingSettings', ['getOnboardingSettings']);
+    const spenderOnboardingServiceSpy = jasmine.createSpyObj('SpenderOnboardingService', ['getOnboardingStatus']);
 
     TestBed.configureTestingModule({
       declarations: [SwitchOrgPage, ActiveOrgCardComponent, OrgCardComponent, FyZeroStateComponent],
@@ -280,7 +280,10 @@ describe('SwitchOrgPage', () => {
     component.searchOrgsInput = fixture.debugElement.query(By.css('.smartlook-show'));
     component.contentRef = fixture.debugElement.query(By.css('.switch-org__content-container__content-block'));
     fixture.detectChanges();
-    spyOn(component, 'navigateToDashboard').and.callThrough();
+    spenderOnboardingService.getOnboardingStatus.and.returnValue(
+      of({ ...onboardingStatusData, state: OnboardingState.COMPLETED })
+    );
+    orgSettingsService.get.and.returnValue(of(orgSettingsData));
   }));
 
   it('should create', () => {
@@ -568,6 +571,16 @@ describe('SwitchOrgPage', () => {
     }));
   });
 
+  it('navigateToDashboard(): should navigate to spender onboarding when onboarding status is not complete', fakeAsync(() => {
+    spenderOnboardingService.getOnboardingStatus.and.returnValue(
+      of({ ...onboardingStatusData, state: OnboardingState.YET_TO_START })
+    );
+    orgSettingsService.get.and.returnValue(of(orgSettingsData));
+    component.navigateToDashboard();
+    tick();
+    expect(router.navigate).toHaveBeenCalledOnceWith(['/', 'enterprise', 'spender_onboarding']);
+  }));
+
   describe('navigateToSetupPage():', () => {
     it('should navigate to setup page if org the roles has OWNER', () => {
       component.navigateToSetupPage(['OWNER']);
@@ -592,7 +605,12 @@ describe('SwitchOrgPage', () => {
       .pipe(
         finalize(() => {
           expect(loaderService.hideLoader).toHaveBeenCalledTimes(1);
-          expect(router.navigate).toHaveBeenCalledOnceWith(['/', 'enterprise', 'my_dashboard']);
+          expect(router.navigate).toHaveBeenCalledOnceWith([
+            '/',
+            'enterprise',
+            'my_dashboard',
+            { openSMSOptInDialog: undefined },
+          ]);
         })
       )
       .subscribe((res) => {
@@ -675,7 +693,12 @@ describe('SwitchOrgPage', () => {
       tick();
       component.navigateBasedOnUserStatus(config).subscribe((res) => {
         expect(res).toBeNull();
-        expect(router.navigate).toHaveBeenCalledOnceWith(['/', 'enterprise', 'my_dashboard']);
+        expect(router.navigate).toHaveBeenCalledOnceWith([
+          '/',
+          'enterprise',
+          'my_dashboard',
+          { openSMSOptInDialog: undefined },
+        ]);
       });
     }));
 

src/app/auth/switch-org/switch-org.page.ts

@@ -321,7 +321,8 @@ export class SwitchOrgPage implements OnInit, AfterViewChecked {
     forkJoin([this.orgSettingsService.get(), this.spenderOnboardingService.getOnboardingStatus()]).subscribe(
       ([orgSettings, onboardingStatus]) => {
         if (
-          (orgSettings.visa_enrollment_settings.enabled ||
+          (orgSettings.corporate_credit_card_settings.enabled ||
+            orgSettings.visa_enrollment_settings.enabled ||
             orgSettings.mastercard_enrollment_settings.enabled ||
             orgSettings.amex_feed_enrollment_settings.enabled) &&
           onboardingStatus.state !== OnboardingState.COMPLETED

src/app/core/services/spender-onboarding.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { map, Observable } from 'rxjs';
+import { BehaviorSubject, map, Observable } from 'rxjs';
 import { SpenderPlatformV1ApiService } from './spender-platform-v1-api.service';
 import { PlatformApiResponse } from '../models/platform/platform-api-response.model';
 import { OnboardingWelcomeStepStatus } from '../models/onboarding-welcome-step-status.model';
@@ -10,6 +10,8 @@
   providedIn: 'root',
 })
 export class SpenderOnboardingService {
+  onboardingComplete$: BehaviorSubject<boolean> = new BehaviorSubject(true);
+
   constructor(private spenderPlatformV1ApiService: SpenderPlatformV1ApiService) {}
 
   getOnboardingStatus(): Observable<OnboardingStatus> {
@@ -78,4 +80,14 @@
     };
     return this.processSmsOptInStep(data);
   }
+
+  setOnboardingStatusAsComplete(): Observable<boolean> {
+    return this.onboardingComplete$.asObservable();
+  }
+
+  // Emit a new event
+  setOnboardingStatusEvent(): void {
+    this.onboardingComplete$.next(true);
+    console.log('event set');
+  }
 }

src/app/fyle/spender-onboarding/spender-onboarding-connect-card-step/spender-onboarding-connect-card-step.component.html

@@ -22,12 +22,13 @@
               <input
                 class="smartlook-show connect-card__card-number-input pl-0"
                 inputmode="numeric"
-                mask="0000 0000 0000 0000"
+                mask="0000 0000 0000"
                 placeholder="xxxx xxxx xxxx"
                 data-testid="card-number-input"
                 formControlName="card_number_{{ card.id }}"
                 required
                 (input)="onCardNumberUpdate(card)"
+                [readonly]="cardValuesMap[card.id].enrollment_success"
               />
 
               <div class="connect-card__card-last-four">