-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FYLE-2891u5w-preview #183
base: main
Are you sure you want to change the base?
FYLE-2891u5w-preview #183
Conversation
summary: Preview of the uploaded statement | ||
description: | | ||
This API helps in converting the statement with the mapping chosed and helps the user to preview it, this doesn't save the statement | ||
operationId: statements_prevew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview
Specifies the mapping name. | ||
example: USD | ||
nullable: true | ||
ignored_line_items: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will the client find the id of the statement line items during the preview stage ? @Kulsekar4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the very first api statements/upload
the statement_line_item_id
which is duplicate would be sent sir.
And here the user can pass those id's
vendor_column: | ||
type: string | ||
description: | | ||
Specifies the vendor of the statement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifies the mapping of vendor on the statement.
type: boolean | ||
description: | | ||
Specifies the representation of the the amount in the statement, if true then the amount represented by | | ||
negative sign are credits, and if false then the amount represented by negative sign are debits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifies the representation of the the amount in the statement, if true then the amount represented by positive sign are debits, and if false then the amount represented by positive sign are credits.
items: | ||
type: string | ||
description: > | ||
This specifies list of line items to be ignored in the statement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statement line items
Specifies the representation of the the amount in the statement, if true then the amount represented by | | ||
negative sign are credits, and if false then the amount represented by negative sign are debits. | ||
example: true | ||
currency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this currency, the currency by default should be the same as home currency, right ?
Are we adding this to do a check in the backend @Kulsekar4 ?
transactions: | ||
type: array | ||
items: | ||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add required
for this object too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added sir
description: | ||
type: string | ||
description: | | ||
Specifies the header name of the description column in the statement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the header name @Kulsekar4
Can use something like below with some changes.
Description of the transaction in the statement as per description column mapping.
Specifies the foreign currency on the statement. | ||
nullable: true | ||
example: USD | ||
transaction_id: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transaction_type
is missing @Kulsekar4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added sir
No description provided.