Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for _search_document #353

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

siddharth-singh-1
Copy link
Contributor

@siddharth-singh-1 siddharth-singh-1 commented Sep 7, 2023

Added the the query param q for search document in it for platform-docs
Screenshot 2023-09-07 at 1 26 28 PM
Screenshot 2023-09-07 at 1 26 57 PM

Copy link
Contributor

@KirtiGautam KirtiGautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@@ -7,6 +7,8 @@ get:

This API supports very rich filtering on all response fields and pagination via query parameters. To understand how to use these parameters, please see the [Guide to Data APIs](https://docs.fylehq.com/docs/fyle-platform-docs/ZG9jOjI3Mzk2NTM3-guide-to-data-ap-is#filtering)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append some sentence to convey extra functionality of q.

Copy link
Contributor

@KirtiGautam KirtiGautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, please update the screenshots.

@@ -6,7 +6,11 @@ get:
This API gets you expenses submitted by any employee in the current organization.

This API supports very rich filtering on all response fields and pagination via query parameters. To understand how to use these parameters, please see the [Guide to Data APIs](https://docs.fylehq.com/docs/fyle-platform-docs/ZG9jOjI3Mzk2NTM3-guide-to-data-ap-is#filtering)

This API supports supports a full text search as well apart from the above-mentioned filtering you can use it by passing it in `q` as a query parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.....above-mentioned filtering. You can use....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants