Improve extensibility of the DiagramWidget #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added background graphic capability and an example of extending a DiagramNode so that vertical movement and resizing are disallowed.
Added DiagramWidget override callbacks for the drawing area Dragged() and DragEnd() functions. Added DiagramElement.SetConnectionPad() function so that custom pads can be added to a DiagramElement. Added example custom pads to the demo.
Pull Request Test Coverage Report for Build 7492839566
💛 - Coveralls |
andydotxyz
requested changes
Sep 24, 2024
| @@ -105,12 +116,12 @@ type PointPad struct { | |||
|
|
|||
| // NewPointPad creates a PointPad and associates it with the DiagramElement. Note that, by default, | |||
| // the position of the PointPad will be (0,0), i.e. the origin of the DiagramElement. | |||
| func NewPointPad(padOwner DiagramElement) *PointPad { | |||
| func NewPointPad(lineWidth float32) *PointPad { | |||
There was a problem hiding this comment.
The documentation here is now out of date.
| @@ -223,11 +234,9 @@ type RectanglePad struct { | |||
|
|
|||
| // NewRectanglePad creates a RectanglePad and associates it with the DiagramElement. The size of the | |||
| // pad becomes the size of the padOwner. | |||
| func NewRectanglePad(padOwner DiagramElement) *RectanglePad { | |||
| func NewRectanglePad() *RectanglePad { | |||
There was a problem hiding this comment.
With this change of signature the documents no longer correctly describe what it does.
What this API break intentional?
| @@ -38,6 +37,9 @@ type DiagramWidget struct { | |||
| // DesiredSize specifies the size of the displayed diagram. Defaults to 800 x 600 | |||
| DesiredSize fyne.Size | |||
|
|
|||
| // MinimumSize is the minimum size for the diagram widget | |||
| MinimumSize fyne.Size | |||
There was a problem hiding this comment.
I don't think this should be exposed as a field - the function MinSize() already returns that information.
| // AnchoredTextChangedCallback is called when the position, offset, or text of the anchored text has changed | ||
| AnchoredTextChangedCallback func(*AnchoredText) | ||
| // DragEndCallback is called when a dragEnd event occurs in the drawing area | ||
| DragEndCallback func() |
There was a problem hiding this comment.
These are pretty much duplicating the existing Fyne events for DragEnd etc - can they be exposed in the way of other widgets such that someone extending the widget can do that and replace the method, delegating back upward to the embedded widget?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve the extensibility of the DiagramWidget. Changes include: