Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added time module and TimeNow Node #111

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Added time module and TimeNow Node #111

merged 1 commit into from
Oct 9, 2024

Conversation

nspielbau
Copy link
Contributor

No description provided.

Signed-off-by: Niklas Spielbauer <spielbauer@fzi.de>
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.44%. Comparing base (0fef933) to head (8d1b528).

Files with missing lines Patch % Lines
ros_bt_py/ros_bt_py/ros_nodes/time.py 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #111      +/-   ##
==========================================
+ Coverage   49.40%   49.44%   +0.03%     
==========================================
  Files          58       59       +1     
  Lines        7681     7700      +19     
  Branches     1658     1659       +1     
==========================================
+ Hits         3795     3807      +12     
- Misses       3822     3829       +7     
  Partials       64       64              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 9, 2024

Test Results

  3 files  ±0    3 suites  ±0   42s ⏱️ ±0s
181 tests ±0  181 ✅ ±0  0 💤 ±0  0 ❌ ±0 
543 runs  ±0  543 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8d1b528. ± Comparison against base commit 0fef933.

♻️ This comment has been updated with latest results.

@nspielbau nspielbau self-assigned this Oct 9, 2024
Copy link
Contributor

@Oberacda Oberacda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me.

@Oberacda Oberacda merged commit 2182741 into dev Oct 9, 2024
9 checks passed
@Oberacda Oberacda deleted the fb_add_time_module branch October 9, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants