fix(quote/cryptocurrency): more optionals; ZRC-USD test (fixes #403)

The follow fields are now optional in response: * coinImageUrl * volume24Hr * volumeAllCurrencies * startDate
gadicc · Feb 26, 2022 · cffe7a6 · cffe7a6
1 parent 1d52360
commit cffe7a6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/schema.json b/schema.json
@@ -1865,7 +1865,6 @@
       },
       "required": [
         "circulatingSupply",
-        "coinImageUrl",
         "customPriceAlertConfidence",
         "esgPopulated",
         "exchange",
@@ -1883,13 +1882,10 @@
         "quoteType",
         "region",
         "sourceInterval",
-        "startDate",
         "symbol",
         "toCurrency",
         "tradeable",
-        "triggerable",
-        "volume24Hr",
-        "volumeAllCurrencies"
+        "triggerable"
       ],
       "additionalProperties": false
     },

diff --git a/src/modules/quote.spec.ts b/src/modules/quote.spec.ts
@@ -7,6 +7,7 @@ const testSymbols = [
   "AZT.OL", // Far less properties than other symbols (#42)
   "AAPL220121C00025000", // Option
   "LDO.MI", // additionalProperty: underlyingSymbol (#363)
+  "ZRC-USD", // Low cap crypto (#403)
 ];
 
 const marketStates = [

diff --git a/src/modules/quote.ts b/src/modules/quote.ts
@@ -125,10 +125,10 @@ export interface QuoteCryptoCurrency extends QuoteBase {
   fromCurrency: string; // 'BTC'
   toCurrency: string; // 'USD=X'
   lastMarket: string; // 'CoinMarketCap'
-  coinImageUrl: string; // 'https://s.yimg.com/uc/fin/img/reports-thumbnails/1.png'
-  volume24Hr: number; // 62631043072
-  volumeAllCurrencies: number; // 62631043072
-  startDate: Date; // new Date(1367103600 * 1000)
+  coinImageUrl?: string; // 'https://s.yimg.com/uc/fin/img/reports-thumbnails/1.png'
+  volume24Hr?: number; // 62631043072
+  volumeAllCurrencies?: number; // 62631043072
+  startDate?: Date; // new Date(1367103600 * 1000)
 }
 
 export interface QuoteCurrency extends QuoteBase {