Skip to content

Commit

Permalink
Merge pull request #17543 from nsoranzo/release_23.2_fix_17535
Browse files Browse the repository at this point in the history
[23.2] Fix emission estimates typo
  • Loading branch information
nsoranzo committed Feb 26, 2024
2 parents 51ee56e + 6f02027 commit 12a782b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
:geographical-server-location-name="config.geographical_server_location_name"
:power-usage-effectiveness="config.power_usage_effectiveness"
:should-show-aws-estimate="config.aws_estimate"
:should-show-carbon-emissions-estimates="config.carbon_emissions_estimates" />
:should-show-carbon-emission-estimates="config.carbon_emission_estimates" />
<JobDestinationParams v-if="currentUser.is_admin" :job-id="dataset.creating_job" />
<JobDependencies :dependencies="job.dependencies"></JobDependencies>
<div v-if="dataset.peek">
Expand Down
6 changes: 2 additions & 4 deletions client/src/components/JobMetrics/JobMetrics.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const props = defineProps({
type: Boolean,
default: false,
},
shouldShowCarbonEmissionsEstimates: {
shouldShowCarbonEmissionEstimates: {
type: Boolean,
default: true,
},
Expand Down Expand Up @@ -202,9 +202,7 @@ const estimatedServerInstance = computed(() => {
:memory-allocated-in-mebibyte="memoryAllocatedInMebibyte" />

<CarbonEmissions
v-if="
shouldShowCarbonEmissionsEstimates && estimatedServerInstance && jobRuntimeInSeconds && coresAllocated
"
v-if="shouldShowCarbonEmissionEstimates && estimatedServerInstance && jobRuntimeInSeconds && coresAllocated"
:carbon-intensity="carbonIntensity"
:geographical-server-location-name="geographicalServerLocationName"
:power-usage-effectiveness="powerUsageEffectiveness"
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/Markdown/Elements/JobMetrics.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
class="job-metrics"
:job-id="args.job_id"
:should-show-aws-estimate="false"
:should-show-carbon-emissions-estimates="false"
:should-show-carbon-emission-estimates="false"
:include-title="false" />
</b-card>
</template>
Expand Down

0 comments on commit 12a782b

Please sign in to comment.