Skip to content

Commit

Permalink
add alert for no metrics, lint
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmedhamidawan committed Nov 12, 2024
1 parent 05efa1e commit e9f3211
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 2 additions & 0 deletions client/src/components/JobMetrics/JobMetrics.vue
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<script setup lang="ts">
import { BAlert } from "bootstrap-vue";
import { computed, ref, unref, watch } from "vue";
import { useJobMetricsStore } from "@/stores/jobMetricsStore";
Expand Down Expand Up @@ -217,4 +218,5 @@ const estimatedServerInstance = computed(() => {
:cores-allocated="coresAllocated"
:memory-allocated-in-mebibyte="memoryAllocatedInMebibyte" />
</div>
<BAlert v-else variant="info" show> No metrics available for this job. </BAlert>
</template>
1 change: 1 addition & 0 deletions client/src/components/Workflow/WorkflowAnnotation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const workflowTags = computed(() => {
<SwitchToHistoryLink :history-id="props.historyId" />
</span>
</div>
<slot name="middle-content" />
<div class="d-flex align-items-center">
<div class="d-flex flex-column align-items-end mr-2">
<WorkflowIndicators :workflow="workflow" published-view no-edit-time />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,9 @@ const jobStatesSummary = computed(() => {
return (!jobsSummary ? null : jobsSummary) as InvocationJobsSummary;
});
const invocationStateSuccess = computed(() => {
return (
invocationState.value == "scheduled" &&
runningCount.value === 0 &&
invocationAndJobTerminal.value
);
return invocationState.value == "scheduled" && runningCount.value === 0 && invocationAndJobTerminal.value;
});
type StepStateType = { [state: string]: number };
const stepStates = computed<StepStateType>(() => {
Expand Down

0 comments on commit e9f3211

Please sign in to comment.