assert_contents skips tests if no outputs are produced
#17829
Labels
Comments
mvdbeek
added a commit
to mvdbeek/tools-iuc
that referenced
this issue
Mar 25, 2024
The outputs were never going to be produced. Together with galaxyproject/galaxy#17829 we ended up with passing tests when they should have failed.
5 tasks
|
The problem may actually be that Galaxy fails to prepare the jobs at all (and that this goes unnoticed). Probably because the job produces no outputs at all? Anyway we should produce an error somehow. If you run the test then you see 4 job working directories. The two for the actual tool runs are incomplete, e.g. no job or tool script. |
|
This assertion is raised and this goes unnoticed. |
|
Got it. Ended up nearly at the same as #16094, but maybe its better to move the assertion into the |
4 tasks
bernt-matthias
pushed a commit
to galaxyproject/tools-iuc
that referenced
this issue
Mar 25, 2024
* Fix bam2fastx outputs The outputs were never going to be produced. Together with galaxyproject/galaxy#17829 we ended up with passing tests when they should have failed. * Bump version
|
Should be fixed in #17874, but still needs new packages and galaxyproject/planemo#1441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Might apply to more than just
assert_contents.See https://github.com/galaxyproject/tools-iuc/pull/5830/files#diff-495875e87b2551855bb16ba2e6be513e7517632dbaea4dc8e4c582a448061cf7R42-R61, which runs assertions against outputs that are never produced.
Tests should fail at this point, however we got a successful test output
The text was updated successfully, but these errors were encountered: