-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make columns types an empty list for empty tabular data #13918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
tabular-improvement
branch
2 times, most recently
from
May 14, 2022 08:28
3ad6bef
to
943836c
Compare
bernt-matthias
force-pushed
the
tabular-improvement
branch
6 times, most recently
from
May 16, 2022 12:52
0b937ed
to
2604602
Compare
bernt-matthias
changed the title
Some improvements to tabular
Some improvements to tabular/data
May 18, 2022
Assigning the 22.09 milestone. Please remove if this is premature. |
4 tasks
to actually check set metadata values
as 0 column files - refactor type_overrules_type for simplicity - add tests
bernt-matthias
force-pushed
the
tabular-improvement
branch
from
February 19, 2024 11:08
b96713f
to
d90a101
Compare
bernt-matthias
changed the title
Some improvements to tabular/data
Empty tabular data has no column types
Feb 19, 2024
bernt-matthias
changed the title
Empty tabular data has no column types
Make columns types an empty list for empty tabular data
Feb 19, 2024
for mock
bernt-matthias
force-pushed
the
tabular-improvement
branch
from
February 19, 2024 15:44
55aa354
to
f198184
Compare
jdavcs
reviewed
Mar 1, 2024
jdavcs
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bernt-matthias! Sorry for delaying with this review!
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rows x cols
(I.e. drop the words lines and columns) for compacter display0 lines 1 colums
?set_meta
which readsMAX_LINES
.. question is if we can assume thatset_meta
runs beforeset_peek
?Tabular.set_meta
.. should this be an inline unit test or another wayHow to test the changes?
(Select all options that apply)
License