Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make columns types an empty list for empty tabular data #13918

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Make columns types an empty list for empty tabular data #13918

merged 5 commits into from
Mar 1, 2024

Commits on Feb 19, 2024

  1. extend existing unit test for Tabular.set_meta 

    to actually check set metadata values
    @bernt-matthias
    bernt-matthias committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9f04af0 View commit details
    Browse the repository at this point in the history

  2. add unit test for Tabular.set_meta for empty files

    @bernt-matthias
    bernt-matthias committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b7ca525 View commit details
    Browse the repository at this point in the history

  3. treat empty files correctly 

    as 0 column files

- refactor type_overrules_type for simplicity
- add tests
    @bernt-matthias
    bernt-matthias committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d90a101 View commit details
    Browse the repository at this point in the history

  4. add type ignores 

    for mock
    @bernt-matthias
    bernt-matthias committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f198184 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Make comment more detailed

    @jdavcs
    jdavcs authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    25d9527 View commit details
    Browse the repository at this point in the history