Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes 2022-06-28 #14215

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Misc fixes 2022-06-28 #14215

merged 5 commits into from
Jun 28, 2022

Conversation

nsoranzo
Copy link
Member

Taking out some self-contained fixes from #12909 and #13909:

  • Fix pseduo_location typo.
  • Add dynamic_tool_manager to MinimalManagerApp (needed for CWL).
  • Add more type annotations.
  • Move uses_shed.py to galaxy_test.driver to break circular dependency between galaxy-test-base and galaxy-test-driver packages.
  • Fail "Run tests" step of Converter CI tests for any planemo test failure (not only failed tool tests)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@nsoranzo
Copy link
Member Author

Green!

@dannon dannon merged commit 1b680cb into galaxyproject:dev Jun 28, 2022
@nsoranzo nsoranzo deleted the misc_fixes_20220628 branch June 28, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants