-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing outputs should be recorded as test errors #16094
Closed
bernt-matthias
wants to merge
12
commits into
galaxyproject:dev
from
bernt-matthias:topic/assert-empty-output
Closed
Missing outputs should be recorded as test errors #16094
bernt-matthias
wants to merge
12
commits into
galaxyproject:dev
from
bernt-matthias:topic/assert-empty-output
Commits on Mar 25, 2024
-
- remove the output that is always present - add a test that has no outputs
Configuration menu - View commit details
-
Copy full SHA for bda3ecf - Browse repository at this point
Copy the full SHA bda3ecfView commit details -
tool verification: move no output assertion
from planemo the verify_tool function is called from [within an try-except block](https://github.com/galaxyproject/planemo/blob/1aa3eb05a97ad20c0be6f6560ab5cec090e76612/planemo/engine/galaxy.py#L109) which silently catches any exception. Thus any exception raised from within verify_tool will not be detected, i.e. the assertion needs to be moved into `_verify_outputs` (which also seems to make sense by name) in order to make verify_tool record the problem properly.
Configuration menu - View commit details
-
Copy full SHA for 2e87de7 - Browse repository at this point
Copy the full SHA 2e87de7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a38e528 - Browse repository at this point
Copy the full SHA a38e528View commit details -
register failure to produce output
thereby we implicitly make the assumption that a test needs to produce an output also make message more specific
Configuration menu - View commit details
-
Copy full SHA for 454d04a - Browse repository at this point
Copy the full SHA 454d04aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e69d9 - Browse repository at this point
Copy the full SHA b1e69d9View commit details -
move assertion instead of removing it
otherwise the tool test will just return a list out of bounds exception which is unclear to the user
Configuration menu - View commit details
-
Copy full SHA for 012ab7d - Browse repository at this point
Copy the full SHA 012ab7dView commit details -
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bb7c082 - Browse repository at this point
Copy the full SHA bb7c082View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad249ef - Browse repository at this point
Copy the full SHA ad249efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11faeaa - Browse repository at this point
Copy the full SHA 11faeaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 705ddca - Browse repository at this point
Copy the full SHA 705ddcaView commit details
Commits on Mar 26, 2024
-
move registering the exception
then it might be clearer what's going on here
Configuration menu - View commit details
-
Copy full SHA for 6ee5b09 - Browse repository at this point
Copy the full SHA 6ee5b09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fe25d1 - Browse repository at this point
Copy the full SHA 3fe25d1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.