Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing outputs should be recorded as test errors #16094

Commits on Mar 25, 2024

  1. adapt output filter test

    - remove the output that is always present
    - add a test that has no outputs
    bernt-matthias committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    bda3ecf View commit details
    Browse the repository at this point in the history
  2. tool verification: move no output assertion

    from planemo the verify_tool function is called from
    [within an try-except block](https://github.com/galaxyproject/planemo/blob/1aa3eb05a97ad20c0be6f6560ab5cec090e76612/planemo/engine/galaxy.py#L109)
    which silently catches any exception.
    
    Thus any exception raised from within verify_tool will not be
    detected, i.e. the assertion needs to be moved into
    `_verify_outputs` (which also seems to make sense by name)
    in order to make verify_tool record the problem properly.
    bernt-matthias committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2e87de7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a38e528 View commit details
    Browse the repository at this point in the history
  4. register failure to produce output

    thereby we implicitly make the assumption that a test needs to produce
    an output
    
    also make message more specific
    bernt-matthias committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    454d04a View commit details
    Browse the repository at this point in the history
  5. register later

    bernt-matthias committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b1e69d9 View commit details
    Browse the repository at this point in the history
  6. move assertion instead of removing it

    otherwise the tool test will just return a list out of bounds exception
    which is unclear to the user
    bernt-matthias committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    012ab7d View commit details
    Browse the repository at this point in the history
  7. Just use the suggestion

    Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
    bernt-matthias and mvdbeek committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    bb7c082 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ad249ef View commit details
    Browse the repository at this point in the history
  9. Add back test output

    bernt-matthias committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    11faeaa View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    705ddca View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. move registering the exception

    then it might be clearer what's going on here
    bernt-matthias committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6ee5b09 View commit details
    Browse the repository at this point in the history
  2. black

    bernt-matthias committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3fe25d1 View commit details
    Browse the repository at this point in the history