Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow anonymous user buttons #17537

Merged

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Feb 23, 2024

Fixes #17514. This PR disables workflow card buttons (edit, import, run) with detailed titles for anonymous users, removes the workflow invocations count widget and rename button, and disables the edit button for non-owners and anonymous users.

Non-owner user

image

Anonymous user

image

Owner

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Share action also requires disabling for anonymous users.

image

Edit: Hmmm after refreshing the page as anonymous the buttons are correctly disabled or removed. So there seems to be a reactivity issue when the user logs out.

AnonymousUser

@bgruening
Copy link
Member

@itisAliRH this needs a rebase please

@itisAliRH itisAliRH force-pushed the workflow-anonymous-user-buttons branch from 8bafe33 to 2c96640 Compare February 26, 2024 12:44
@itisAliRH
Copy link
Member Author

Looks like the Share action also requires disabling for anonymous users.

image

Edit: Hmmm after refreshing the page as anonymous the buttons are correctly disabled or removed. So there seems to be a reactivity issue when the user logs out.

AnonymousUser AnonymousUser

@davelopez Thanks for your comment. Both are fixed now ✌🏻

@davelopez
Copy link
Contributor

Thank you!

@davelopez davelopez merged commit c00a47a into galaxyproject:dev Feb 26, 2024
29 of 30 checks passed
@itisAliRH itisAliRH deleted the workflow-anonymous-user-buttons branch February 26, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Workflows have edit and run buttons for anon users
5 participants