Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Workflow API routes - Part 2 #17548

Draft
wants to merge 73 commits into
base: dev
Choose a base branch
from

Conversation

heisner-tillman
Copy link
Contributor

@heisner-tillman heisner-tillman commented Feb 26, 2024

This is a part of #10889 and an extension of #17463.

Summary

  • Refactored API routes:
    • PUT: /api/workflows/menu

      • Added pydantic models to input
      • Added pydantic models to return
      • Removed the mapping to the legacy route
      • Write appropriate tests
    • GET: /api/workflows/download/{workflow_id}, /api/workflows/{workflow_id}/download

      • Added pydantic models to input
      • Added pydantic models to return
      • Removed the mapping to the legacy routes

How to test the changes?

  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    You can find the interactive API documentation here: http://127.0.0.1:8080/api/docs#/workflows
    Screenshot 2024-03-29 at 16-03-07 Galaxy API - Swagger UI

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@heisner-tillman heisner-tillman marked this pull request as draft February 26, 2024 18:36
@heisner-tillman heisner-tillman marked this pull request as ready for review February 26, 2024 18:38
@heisner-tillman
Copy link
Contributor Author

This is not ready for review. I just wanted to create this pull request such that there is no duplication effort

@jdavcs
Copy link
Member

jdavcs commented Feb 26, 2024

This is not ready for review. I just wanted to create this pull request such that there is no duplication effort

Converting to draft.

@jdavcs jdavcs modified the milestones: 24.0, 24.1 Feb 26, 2024
@heisner-tillman heisner-tillman force-pushed the workflows_part_2 branch 5 times, most recently from 86ee5c7 to 8baee31 Compare March 3, 2024 16:27
@heisner-tillman heisner-tillman force-pushed the workflows_part_2 branch 4 times, most recently from 5816361 to 29adbd3 Compare March 15, 2024 20:04
@heisner-tillman heisner-tillman force-pushed the workflows_part_2 branch 4 times, most recently from cb3300c to 3f7b975 Compare March 24, 2024 17:39
@heisner-tillman heisner-tillman force-pushed the workflows_part_2 branch 2 times, most recently from fd0fd85 to a841862 Compare March 29, 2024 12:01
@heisner-tillman heisner-tillman marked this pull request as ready for review March 29, 2024 15:05
@heisner-tillman heisner-tillman force-pushed the workflows_part_2 branch 2 times, most recently from 1aa8ae2 to 08249c0 Compare April 1, 2024 16:57
…API and add tool specific step model for runsummary model
…t in internal manager method _workflow_to_dict_export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants