Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Workflow API routes - Part 2 #17548

Draft
wants to merge 73 commits into
base: dev
Choose a base branch
from
Draft

Refactor Workflow API routes - Part 2 #17548

wants to merge 73 commits into from
+3,145 −458

Commits on Sep 23, 2024

  1. Add set_workflow_menu method to service layer of the Workflows API

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a9f1352 View commit details
    Browse the repository at this point in the history

  2. Create pydantic models for the set_workflow_menu operation of the Wor… 

    …kflowsAPI
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    69d0839 View commit details
    Browse the repository at this point in the history

  3. Refactor set_workflow_menu operation to FastAPI

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bcf07e4 View commit details
    Browse the repository at this point in the history

  4. Remove the mapping to the legacy route

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5e27757 View commit details
    Browse the repository at this point in the history

  5. Add TODO

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1fc7e39 View commit details
    Browse the repository at this point in the history

  6. Type payload of set_workflow_menu operation properly

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    18ea3ef View commit details
    Browse the repository at this point in the history

  7. Mark HistoryId query param as invocation specific

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8bf1a2f View commit details
    Browse the repository at this point in the history

  8. Refactor workflow_dict operation to FastAPI

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    92d29c3 View commit details
    Browse the repository at this point in the history

  9. Create service method for workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7ace91f View commit details
    Browse the repository at this point in the history

  10. Remove mapping to legacy routes

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5ffd8ae View commit details
    Browse the repository at this point in the history

  11. Regenerate the client schema

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bbccfe7 View commit details
    Browse the repository at this point in the history

  12. Remove unused internal method in legacy WorkflowsAPIController

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9c60fd7 View commit details
    Browse the repository at this point in the history

  13. Use the correct get_workflow method from WorkflowsManager

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9d811b0 View commit details
    Browse the repository at this point in the history

  14. Type yaml return of download_workflow method

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    75c0f7b View commit details
    Browse the repository at this point in the history

  15. Add pydantic models for return of workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a8ec759 View commit details
    Browse the repository at this point in the history

  16. Type return of download method

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    69bbb50 View commit details
    Browse the repository at this point in the history

  17. Add return model

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5c54863 View commit details
    Browse the repository at this point in the history

  18. Make label optional in steps model of editor and run workflowdictsummary

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d30ca46 View commit details
    Browse the repository at this point in the history

  19. Add step model for WorkflowDictExportSummary

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1d8ba73 View commit details
    Browse the repository at this point in the history

  20. Change type of input_connections field in step model for WorkflowExpo… 

    …rtSummary
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    177ad20 View commit details
    Browse the repository at this point in the history

  21. Add pydantic model for workflowdict in format2 version

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    645db8b View commit details
    Browse the repository at this point in the history

  22. Add pydantic models to return of workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3fc024f View commit details
    Browse the repository at this point in the history

  23. Add further typing to return of download_workflow method

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d531b6e View commit details
    Browse the repository at this point in the history

  24. Properly type creator in pydantic models of workflowdict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b88190c View commit details
    Browse the repository at this point in the history

  25. Add alias for format_version field in pydantic model of workflowdict … 

    …operation
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    aae4557 View commit details
    Browse the repository at this point in the history

  26. Regenerate the client schema

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c98190f View commit details
    Browse the repository at this point in the history

  27. Create base model for step models of WorkflowSummary models

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    356d44a View commit details
    Browse the repository at this point in the history

  28. Create base model for step models of WorkflowSummary models

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ce91a39 View commit details
    Browse the repository at this point in the history

  29. Add annotation field to pydantic model of workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ade337f View commit details
    Browse the repository at this point in the history

  30. Fix typing of error field in base of step models of workflowdictsumma… 

    …ry models
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9cc4515 View commit details
    Browse the repository at this point in the history

  31. Fix typing in WorkflowDictFormat2WrappedYamlSummary model

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    54c0a01 View commit details
    Browse the repository at this point in the history

  32. Add test for set_workflow_menu operation from WorfklowAPI

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    df6f0b8 View commit details
    Browse the repository at this point in the history

  33. Refine descriptions in pydantic models for workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d1cad09 View commit details
    Browse the repository at this point in the history

  34. Move old and unused WorkflowToExport model to workflow schema file

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    901dae7 View commit details
    Browse the repository at this point in the history

  35. Fix style error in test_set_workflow_menu

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    78d08ff View commit details
    Browse the repository at this point in the history

  36. Add type to uuid field

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5866b77 View commit details
    Browse the repository at this point in the history

  37. Move workflow specific model to the workflow schema file

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f516c4e View commit details
    Browse the repository at this point in the history

  38. Add typing to position field in base model of workflowdictsteps

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7b6d62a View commit details
    Browse the repository at this point in the history

  39. Add further typing to step models of workflowdict

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ca4c395 View commit details
    Browse the repository at this point in the history

  40. Allow float type for fields WorkflowStepLayoutPosition model

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d493ed2 View commit details
    Browse the repository at this point in the history

  41. Allow str as replacement_parameter in WorkflowDictRunSteps model

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f10863c View commit details
    Browse the repository at this point in the history

  42. Allow str type for step_version_changes field in WorkflowDictRunSumma… 

    …ry model
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    516011c View commit details
    Browse the repository at this point in the history

  43. Move workflow specific models to the workflow schema file

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e840d32 View commit details
    Browse the repository at this point in the history

  44. Refine tpying in pydantic models of workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    62528ff View commit details
    Browse the repository at this point in the history

  45. Type in_parameter field in WorkflowDictExportSteps with new model and… 

    … add more comments
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    57770ad View commit details
    Browse the repository at this point in the history

  46. Adjsut typing of field post_job_actions in model WorkflowDictStepsBase

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5dce471 View commit details
    Browse the repository at this point in the history

  47. Remove comments

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c52e3ab View commit details
    Browse the repository at this point in the history

  48. Refine return models of the workflow_dict operation from the WorkflowAPI

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1946b6f View commit details
    Browse the repository at this point in the history

  49. Remove comments

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    314e026 View commit details
    Browse the repository at this point in the history

  50. Refine return models of the workflow_dict operation from the WorkflowAPI

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e565895 View commit details
    Browse the repository at this point in the history

  51. Refine return models of the workflow_dict operation from the Workflow… 

    …API and add tool specific step model for runsummary model
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5cebbdc View commit details
    Browse the repository at this point in the history

  52. Remove comment

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2b323df View commit details
    Browse the repository at this point in the history

  53. Remove unused imports

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f01ecd3 View commit details
    Browse the repository at this point in the history

  54. Apply suggested changes

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    90eff8f View commit details
    Browse the repository at this point in the history

  55. Remove the description from fields, where the description equals to TODO

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b203965 View commit details
    Browse the repository at this point in the history

  56. Limit type of field x and y fields in WorkflowStepLayoutPosition to i… 

    …nteger
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7a4f08f View commit details
    Browse the repository at this point in the history

  57. Make sure tag_str is always of type list, when assigning a value to i… 

    …t in internal manager method _workflow_to_dict_export
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4684459 View commit details
    Browse the repository at this point in the history

  58. Specify valid style types for query param of workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0f13941 View commit details
    Browse the repository at this point in the history

  59. Apply code suggestions

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f230bb3 View commit details
    Browse the repository at this point in the history

  60. Allow list of empty string for tags field in WorkflowDictExportSummary

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f5e232c View commit details
    Browse the repository at this point in the history

  61. Move field tool_id to explicit step models to enable more specific ty… 

    …ping
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0aeb1e9 View commit details
    Browse the repository at this point in the history

  62. Split model InputConnections into more specific models to use them in… 

    … different step models
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f8ae6a5 View commit details
    Browse the repository at this point in the history

  63. temporary change for debugging

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9c52d2d View commit details
    Browse the repository at this point in the history

  64. Fix typo in service method of the workflow_dict operation

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bb99760 View commit details
    Browse the repository at this point in the history

  65. Add field_validator for tool_state field in step basemodel to deseria… 

    …lize json string
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    08b00b5 View commit details
    Browse the repository at this point in the history

  66. Change typing of field tool_state in step base model to allow strings

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e9dc08b View commit details
    Browse the repository at this point in the history

  67. Formalize error type for WorkflowDictStepsBase model

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    bcd20c0 View commit details
    Browse the repository at this point in the history

  68. Model output field in WorkflowDictStepsBase and move it to the indivi… 

    …dual step models
    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    dac8e28 View commit details
    Browse the repository at this point in the history

  69. Make hints about where StepOutput models are populated more general

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4822273 View commit details
    Browse the repository at this point in the history

  70. Make necessary fields in ToolModuleStepOutput model optional

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    15aa79a View commit details
    Browse the repository at this point in the history

  71. Fix typing of the field tags in the WorkflowDictExportSummary model

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d20eb22 View commit details
    Browse the repository at this point in the history

  72. Fix assignment of tags in _workflow_to_dict_export method

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a52bcb5 View commit details
    Browse the repository at this point in the history

  73. Regenerate the client schema

    @heisner-tillman
    heisner-tillman committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    21e25c8 View commit details
    Browse the repository at this point in the history