Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Associate default history with session when creating a new session #17557

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 27, 2024

Fixes the missing history panel when opening Galaxy the first time as an anon user.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Feb 27, 2024
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It works well now!

@davelopez davelopez merged commit 73d5032 into galaxyproject:release_23.2 Feb 28, 2024
33 of 46 checks passed
@nsoranzo nsoranzo deleted the default_history_new_session branch March 4, 2024 12:15
@nsoranzo
Copy link
Member

nsoranzo commented Mar 4, 2024

@mvdbeek I think this broke the ToolShed tests on 23.2 .

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 5, 2024

Yep, definitely does

@davelopez
Copy link
Contributor

Sorry my bad, I thought it was the flakiness that we have been seeing recently on Toolshed tests I didn't properly check because I thought this wouldn't affect Toolshed stuff at all. I will be more careful next time.

@nsoranzo nsoranzo mentioned this pull request Mar 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants