[24.0] Record missing outputs as test errors #17874
Merged
Commits on Apr 2, 2024
-
- remove the output that is always present - add a test that has no outputs
-
tool verification: move no output assertion
from planemo the verify_tool function is called from [within an try-except block](https://github.com/galaxyproject/planemo/blob/1aa3eb05a97ad20c0be6f6560ab5cec090e76612/planemo/engine/galaxy.py#L109) which silently catches any exception. Thus any exception raised from within verify_tool will not be detected, i.e. the assertion needs to be moved into `_verify_outputs` (which also seems to make sense by name) in order to make verify_tool record the problem properly.
-
-
register failure to produce output
thereby we implicitly make the assumption that a test needs to produce an output also make message more specific
-
-
move assertion instead of removing it
otherwise the tool test will just return a list out of bounds exception which is unclear to the user
-
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
-
-
-
-
move registering the exception
then it might be clearer what's going on here
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.