[24.0] Adds logging of messageExceptions in the fastapi exception handler.

[dannon]

We're intentionally not doing a full log.exception with the traceback here, though we could. This exception will also be dispatched to Sentry if configured, this just makes logs less opaque when one sees a 500.

Ping @natefoo -- this will now show something like this, so you at least know what the error was from the logs.

galaxy.webapps.base.api ERROR 2024-04-22 17:36:23,219 [pN:main.1,p:10417,tN:MainThread] MessageException: PDF conversion service not available.
uvicorn.access INFO 2024-04-22 17:36:23,221 [pN:main.1,p:10417,tN:MainThread] 127.0.0.1:44056 - "GET /api/invocations/79966582feb6c081/report.pdf HTTP/1.1" 501

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[dannon]

Test failure is legit -- MessageException has a __str__ method that can actually return a dict, which is not great. I'll dig through and address one end or the other of that. Need to review all use of it, but it feels like we should clean up the typing here and enforce a string primary message input for these.

[jmchilton]

xref https://github.com/galaxyproject/galaxy/pull/15868/files

[dannon]

xref https://github.com/galaxyproject/galaxy/pull/15868/files

Unfortunate to have wasted some time tracking down the same issues a year later. So... still draft?

[mvdbeek]

There's another conflict @dannon, and do you want to target 24.0 ? d8951c4 fixes a bug that leads to the default error message (Request failed., which isn't super helpful) being shown in

galaxy/client/src/components/Workflow/Run/WorkflowRun.vue

Line 26 in 516f541

Workflow submission failed: {{ submissionError }}

[dannon]

@mvdbeek Sure, I'll rebase and retarget.