Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Adds logging of messageExceptions in the fastapi exception handler. #18041

Merged
merged 7 commits into from
May 3, 2024
Merged

[24.0] Adds logging of messageExceptions in the fastapi exception handler. #18041

merged 7 commits into from
May 3, 2024

Commits on May 1, 2024

  1. Adds logging of messageExceptions in the fastapi exception handler. 

    We're intentionally not doing a full log.exception with the traceback
here, though we could.  This exception will also be dispatched to Sentry
if configured, this just makes logs less opaque when one sees a 500.
    @dannon
    dannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2a083fa View commit details
    Browse the repository at this point in the history

  2. Force MessageExceptions used in workflow modules to have a string err… 

    …or message.
    @dannon
    dannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    114803b View commit details
    Browse the repository at this point in the history

  3. Chage MessageException typing to only accept str as err_msg.

    @dannon
    dannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    28f0fc8 View commit details
    Browse the repository at this point in the history

  4. Downgrade message to log.info to avoid sending redundantly to sentry

    @dannon
    dannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    52a7a14 View commit details
    Browse the repository at this point in the history

  5. Only log if it's a 500

    @dannon
    dannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1c1317b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
    @dannon @mvdbeek
    dannon and mvdbeek committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e2798c9 View commit details
    Browse the repository at this point in the history

  7. Fix imports after suggestions from code review.

    @dannon
    dannon committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e5c59e1 View commit details
    Browse the repository at this point in the history