Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts router push to Typescript #18072

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Converts router push to Typescript #18072

wants to merge 1 commit into from

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 30, 2024 •
edited
Loading

Requires #18016. Converts router push helper to typescript. Might not be necessary or can be done after the Vue3 transition has occurred to avoid merge conflicts.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Apr 30, 2024
@guerler guerler added this to the 24.1 milestone Apr 30, 2024
@jdavcs jdavcs modified the milestones: 24.1, 24.2 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@guerler @jdavcs