Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamics options add library dataset #18198

Merged

Conversation

gagayuan
Copy link
Contributor

dynamics options add Library Dataset support, Fix a bug where the parameter value of from_dataset does not take effect on Library Dataset( The file selected by the user from the Library ). Although the files selected by the user from the current history are effective.

<param name="tsvFile" type="data" label="model" help=""/>
<param name="pattern_select" type="select" label="pattern" help="">
    <options from_dataset="tsvFile">
        <column name="name" index="0"/>
        <column name="value" index="1"/>
    </options>
</param>

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Add the above code about 'from_dataset' to the XML of a tool
    2. Select a tsv file from the current history in the front-end. The dropdown list will display the file's content normally.
    3. Add this tsv file to a new created Library and select it from the Library in the front-end, you will find that dropdown list cannot be displayed.
    4. Then update the code to support the Library file, select the tsv file again from the Library, and find that the dropdown list can display the content normally.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

gagayuan and others added 2 commits May 22, 2024 10:19
…ameter value of from_dataset does not take effect on Library Dataset
@github-actions github-actions bot added this to the 24.2 milestone May 22, 2024
@mvdbeek mvdbeek merged commit 504b559 into galaxyproject:dev Nov 12, 2024
49 of 52 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@bgruening
Copy link
Member

Thanks a lot @gagayuan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants