Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Make sure that all Linter subclasses are imported for listing them #18339

Merged

Conversation

bernt-matthias
Copy link
Contributor

Otherwise planemo prints out an error Unknown linter type(s) .... (and continues anyway ... but I think we should fix this).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine.

@jdavcs
Copy link
Member

jdavcs commented Jun 6, 2024

Given that we are touching this method here, and assuming the method name is a typo from #17081), should we change it back to list_linters? (this would have to be fixed in planemo too - there's one call in lint.py.

bernt-matthias added a commit to bernt-matthias/planemo that referenced this pull request Jun 6, 2024
@nsoranzo
Copy link
Member

nsoranzo commented Jun 6, 2024

You also need to fix the type in test/unit/tool_util/test_tool_linters.py

bernt-matthias and others added 3 commits June 6, 2024 19:05
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@bernt-matthias
Copy link
Contributor Author

@nsoranzo Can't find a solution to define an alias for a class method (and in particular no nice solution).

@nsoranzo
Copy link
Member

nsoranzo commented Jun 7, 2024

@bernt-matthias I'll push a fix to your branch.

@mvdbeek mvdbeek merged commit d295669 into galaxyproject:release_24.0 Jun 12, 2024
48 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@bernt-matthias bernt-matthias deleted the topic/linter_list_import branch June 12, 2024 14:01
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants