Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FolderTopBar to TypeScript #18488

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Refactor FolderTopBar to TypeScript #18488

merged 10 commits into from
Aug 5, 2024

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Jul 2, 2024 •
edited
Loading

This PR is refactoring the FolderTopBar to use TypeScript and remove jQuery and Backbone usage.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

davelopez
davelopez reviewed Jul 3, 2024
View reviewed changes
client/src/api/datatypes.ts Outdated Show resolved Hide resolved
client/src/api/genomes.ts Outdated Show resolved Hide resolved
client/src/components/Libraries/LibraryFolder/TopToolbar/FolderTopBar.vue Outdated Show resolved Hide resolved
@itisAliRH itisAliRH mentioned this pull request Jul 9, 2024
Merged
7 tasks
@itisAliRH itisAliRH changed the title [WIP] Libraries Modernisation Libraries Modernisation: Refactor FolderTopBar to TypeScript Aug 2, 2024
@itisAliRH itisAliRH changed the title Libraries Modernisation: Refactor FolderTopBar to TypeScript Refactor FolderTopBar to TypeScript Aug 2, 2024
@github-actions github-actions bot added this to the 24.2 milestone Aug 2, 2024
davelopez
davelopez approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @itisAliRH!

client/src/components/Libraries/LibraryFolder/TopToolbar/FolderTopBar.vue Show resolved Hide resolved
@davelopez davelopez merged commit 10434a0 into galaxyproject:dev Aug 5, 2024
33 checks passed
@itisAliRH itisAliRH deleted the libraries-modernization-1 branch September 9, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@itisAliRH @davelopez