Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow Invocation view improvements #18615

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Workflow Invocation view improvements #18615

wants to merge 17 commits into from

Commits on Sep 3, 2024

  1. Workflow Invocation view improvements 

    This first commit tackles point A in the roadmap:

List of invocations is now not visible continously, it goes away after you settle on one invocation and `mouseleave` the panel area.

Roadmap: https://hackmd.io/@nekrut/HkinoEh8A
    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0e7f1ef View commit details
    Browse the repository at this point in the history

  2. move invocation steps to a separate tab, show whole step below 

    - Instead of showing steps right next to the invocation graph, moves steps (back) into a separate tab
- To make this work, adds a `graphStepsByStoreId` to the `invocationStore` that helps access the graph steps in multiple components (TODO: improve how this is done)
- Instead of clicking on a node/step in the graph and showing the job for the step that the user clicks, now we show the whole expanded step below
    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    75a13ab View commit details
    Browse the repository at this point in the history

  3. add workflow input indicator to WorkflowInvocationStepHeader

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    de96bfe View commit details
    Browse the repository at this point in the history

  4. decrease step header size in InvocationGraph to "sm" 

    add gap between step header buttons
    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b54703c View commit details
    Browse the repository at this point in the history

  5. add a tab view for jobs under a step in invocation view

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e07609c View commit details
    Browse the repository at this point in the history

  6. use openapi-fetch for fetching job

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    69023eb View commit details
    Browse the repository at this point in the history

  7. remove redundant props/emits for invocation steps

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    43a62b4 View commit details
    Browse the repository at this point in the history

  8. convert ProgressBar.vue to composition API + ts

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d6cb058 View commit details
    Browse the repository at this point in the history

  9. do not include Steps tab for subworkflows

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    24a2921 View commit details
    Browse the repository at this point in the history

  10. add getContentItemState function

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d09f9cc View commit details
    Browse the repository at this point in the history

  11. add job duration, WorkflowInvocationJob component 

    remove `JobStepTabs.vue`
    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9d5b1a1 View commit details
    Browse the repository at this point in the history

  12. check activeNodeId for null (it can be 0 as well)

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9e92723 View commit details
    Browse the repository at this point in the history

  13. show workflow input value on graph

    @ahmedhamidawan
    ahmedhamidawan committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0841ef9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. move progress bars to header, shorten WorkflowRunSuccess 

    - The progress bars are in `WorkflowInvocationHeader` now, giving more space to the step header being visible below the graph
- `WorkflowRunSuccess` is a one line header (refactored), and it uses `GridInvocation` to show batch invocations.
    @ahmedhamidawan
    ahmedhamidawan committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    642b3a6 View commit details
    Browse the repository at this point in the history

  2. do not auto scroll to the clicked step

    @ahmedhamidawan
    ahmedhamidawan committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f5ef84a View commit details
    Browse the repository at this point in the history

  3. add force prop to WorkflowRunButton for routing

    @ahmedhamidawan
    ahmedhamidawan committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8e6449a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. remove jest since buttons have moved to parent

    @ahmedhamidawan
    ahmedhamidawan committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ea041f5 View commit details
    Browse the repository at this point in the history