-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bundled/requested node version to 20.16.0 #18710
base: dev
Are you sure you want to change the base?
Conversation
c3f07b9
to
a06f5cf
Compare
a06f5cf
to
4ff61c4
Compare
I think these 2 workflows should be updated too: galaxy/.github/workflows/jest.yaml Line 19 in 19bc932
galaxy/.github/workflows/js_lint.yaml Line 19 in 19bc932
|
Good call, missed those in the grep for the specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
(draft while I tinker with github actions -- was trying to refactor so that we have a single setup-node composite action w/ a predefined or default version that we reuse, instead of copying it 10 times) |
bff9d8c
to
83f05cd
Compare
See node release chart: https://nodejs.org/en/about/previous-releases Node 20 is the current "Active LTS" and will be so until node 22 enters active LTS later this fall.
1cab715
to
ddd66bb
Compare
Upgrades bundled/default node to the active LTS node v20. See release schedule here: https://nodejs.org/en/about/previous-releases
Node 18 is in maintenance mode for another 8 months or so, but by then 22 will be the active LTS.
Updates actions to use this. We could, instead, add multiple versions to the matrix but since we ship a specific version for compatibility we may just want to keep the tests focused?
How to test the changes?
(Select all options that apply)
License