Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundled/requested node version to 20.16.0 #18710

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

dannon
Copy link
Member

@dannon dannon commented Aug 15, 2024

Upgrades bundled/default node to the active LTS node v20. See release schedule here: https://nodejs.org/en/about/previous-releases

Node 18 is in maintenance mode for another 8 months or so, but by then 22 will be the active LTS.

Updates actions to use this. We could, instead, add multiple versions to the matrix but since we ship a specific version for compatibility we may just want to keep the tests focused?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon changed the title Default node version 20 Upgrade bundled/requested node version to 20.16.0 Aug 15, 2024
@dannon dannon marked this pull request as ready for review August 16, 2024 14:45
@github-actions github-actions bot added this to the 24.2 milestone Aug 16, 2024
@davelopez
Copy link
Contributor

I think these 2 workflows should be updated too:

@dannon
Copy link
Member Author

dannon commented Aug 16, 2024

I think these 2 workflows should be updated too:

Good call, missed those in the grep for the specific 18.12.1

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dannon dannon marked this pull request as draft August 19, 2024 15:31
@dannon
Copy link
Member Author

dannon commented Aug 19, 2024

(draft while I tinker with github actions -- was trying to refactor so that we have a single setup-node composite action w/ a predefined or default version that we reuse, instead of copying it 10 times)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants