Don't serialize view of item in delete/purge request #18732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
drop_response_body_delete_datasets
branch
3 times, most recently
from
4c7ed96
to
73176cf
Compare
This is a breaking change for the API, it is motivated by https://sentry.galaxyproject.org/share/issue/3970e49a695f4600bcaeae55021555a9/: ``` Message Unexpected error Stack Trace Newest FileNotFoundError: [Errno 2] No such file or directory: '' File "galaxy/datatypes/interval.py", line 1326, in get_estimated_display_viewport with open(dataset.get_file_name()) as fh: ``` This is a purge request, which does return the entire detailed response, including available display applications. We already check that the dataset isn't purged, but ther celery task often executes between the check and the deletion. I don't think it makes sense to return any data at all here, and there are other endpoints where we simply return 202 or 204, like purging user file source instanes.
Most of the time we just want an OK status code. 202, 204, 200 should all be OK and some of this depends on the Galaxy instance config, so this should be more robust to future changes.
mvdbeek
force-pushed
the
drop_response_body_delete_datasets
branch
from
73176cf
to
030ad6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for the API, it is motivated by https://sentry.galaxyproject.org/share/issue/3970e49a695f4600bcaeae55021555a9/:
This is a purge request, which does return the entire detailed response, including available display applications. We already check that the dataset isn't purged, but the celery task often executes between the check and the deletion.
I don't think it makes sense to return any data at all here, and there are other endpoints where we simply return 202 or 204, like purging user file source instances.
How to test the changes?
(Select all options that apply)
License