Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Workflow Title and Annotation sections #18762

Merged
merged 26 commits into from
Nov 15, 2024
Merged

Add Workflow Title and Annotation sections #18762

merged 26 commits into from
Nov 15, 2024

Commits on Nov 13, 2024

  1. New component for Title and Annotation detail

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    88c6639 View commit details
    Browse the repository at this point in the history

  2. Added expand/collapse for Annotation detail

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    122b1cc View commit details
    Browse the repository at this point in the history

  3. Component upgrade, minor styling changes, code cleanup

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    829258b View commit details
    Browse the repository at this point in the history

  4. Cleaner error handling

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    87b7415 View commit details
    Browse the repository at this point in the history

  5. Added Workflow header 'gray bar' for consistency with Tool Form page … 

    …design
    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0a11bec View commit details
    Browse the repository at this point in the history

  6. Linting prettier

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    701a35a View commit details
    Browse the repository at this point in the history

  7. Update client/src/components/Workflow/Run/WorkflowRunName.vue 

    Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu>
    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3eb9699 View commit details
    Browse the repository at this point in the history

  8. Reverted changes to client/src/components/Workflow/Run/WorkflowRunFor… 

    …m.vue
    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5ac81a4 View commit details
    Browse the repository at this point in the history

  9. Replaced with Workflow-Card component for design consistency with Wor… 

    …kflows Landing Page (instead of design consistency with Workflows Annotation History Panel). Added 'show-actions' Boolean parameter to focus user on running the workflow as consistent with their intended behavior from the prior step; when 'show-actions' equals False, all actions are hidden (note: not same terminology as technical 'read-only' as 'show-actions' also prohibits Share/Favorite which are separate from being able to Edit a workflow).
    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f712553 View commit details
    Browse the repository at this point in the history

  10. Backend code formatting

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a1ddc7f View commit details
    Browse the repository at this point in the history

  11. Update lib/galaxy/managers/workflows.py 

    Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
    @hujambo-dunia @mvdbeek @ahmedhamidawan
    2 people authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ecb1fd1 View commit details
    Browse the repository at this point in the history

  12. Update lib/galaxy/managers/workflows.py 

    Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
    @hujambo-dunia @mvdbeek @ahmedhamidawan
    2 people authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    51f5de6 View commit details
    Browse the repository at this point in the history

  13. Coding convention update

    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    625f5e3 View commit details
    Browse the repository at this point in the history

  14. Added reusability & consistency for Workflow headers on: Workflow Inv… 

    …ocations Page and Workflow Run Form Page
    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ab5bc43 View commit details
    Browse the repository at this point in the history

  15. Added reusability & consistency for Workflow headers on: Workflow Inv… 

    …ocations Page and Workflow Run Form Page
    @hujambo-dunia @ahmedhamidawan
    hujambo-dunia authored and ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1715e96 View commit details
    Browse the repository at this point in the history

  16. update workflow annotation header with the following changes: 

    - No `in_panel` prop in route anymore
- In `lib/galaxy/managers`, all we need is the `workflow.id` so on the front end, for the run form, we can call `useWorkflowInstance(workflow_id)`
- Adjust props and variables in the workflow header to cater for all edge cases such as whether it is rendering for run form or invocation view, workflow is owned or not, is published or not etc.
- Minor style improvements
    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    09346e6 View commit details
    Browse the repository at this point in the history

  17. adjust WorkflowRunButton jest for router push 

    The `BButton :to`, was replaced with a `BButton @click` because the styling in `WorkflowNavigationTitle` worked better with a non `<a>` BButton (using `:to` turns the `<button>` into an `<a>`)
    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b2625b3 View commit details
    Browse the repository at this point in the history

  18. remove unused imports and props

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8947533 View commit details
    Browse the repository at this point in the history

  19. in fact do show the history in run form view; just say "Input History" 

    We removed the switch/view history button from the workflow run form version of the header, but it actually makes sense to keep it there since it lets the user know which history is going to be the input for the workflow (it changes as you change the history).

In the invocation version of course it always made sense because then it is scoped to the history that was used as input for that invocation.
    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    632955a View commit details
    Browse the repository at this point in the history

  20. add a jest each for WorkflowAnnotation and WorkflowNavigationTitle

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fa9aa73 View commit details
    Browse the repository at this point in the history

  21. include workflow error in WorkflowNavigationTitle

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    baa3e55 View commit details
    Browse the repository at this point in the history

  22. prevent users from importing workflow over and over

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9f1522b View commit details
    Browse the repository at this point in the history

  23. add space below individual invocation id in GridInvocation

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    32c8c7c View commit details
    Browse the repository at this point in the history

  24. add alert for no metrics, lint

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3bd965b View commit details
    Browse the repository at this point in the history

  25. add badge for workflow run resulting in a new history

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    377c5cf View commit details
    Browse the repository at this point in the history

  26. fix jests for workflow header and job metrics

    @ahmedhamidawan
    ahmedhamidawan committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    aca94f4 View commit details
    Browse the repository at this point in the history