Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix unspecified oidc_endpoint variable overwriting specified redirect_url #18818

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

bgruening
Copy link
Member

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added the area/auth Authentication and authorization label Sep 16, 2024
@github-actions github-actions bot added this to the 24.1 milestone Sep 16, 2024
@mvdbeek mvdbeek changed the title fix for https://github.com/galaxyproject/galaxy/issues/18816 [24.1] Fix unspecified oidc_endpoint overwriting specified redirect_url Sep 16, 2024
@mvdbeek mvdbeek changed the title [24.1] Fix unspecified oidc_endpoint overwriting specified redirect_url [24.1] Fix unspecified oidc_endpoint variable overwriting specified redirect_url Sep 16, 2024
@bgruening bgruening merged commit 106b038 into galaxyproject:release_24.1 Sep 16, 2024
51 of 52 checks passed
@bgruening
Copy link
Member Author

Thanks a lot @mvdbeek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Authentication and authorization kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants