Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Library Contents API to FastAPI #18838

Merged
merged 77 commits into from
Oct 7, 2024
Merged

Migrate Library Contents API to FastAPI #18838

merged 77 commits into from
Oct 7, 2024

Commits on Sep 12, 2024

  1. Add tests for library contents API

    @arash77
    arash77 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bd70faf View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Deleting and updating not possible for folders! 

    Updating test_update.
    @arash77
    arash77 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d1ac6f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'galaxyproject:dev' into FastAPI_library_contents

    @arash77
    arash77 authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fa8ac49 View commit details
    Browse the repository at this point in the history

  2. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    507e7c3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'galaxyproject:dev' into FastAPI_library_contents

    @arash77
    arash77 authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c04ae31 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4621db9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'galaxyproject:dev' into FastAPI_library_contents

    @arash77
    arash77 authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    321951c View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1450ab2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c5023cd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0f26838 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dfe82e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'galaxyproject:dev' into FastAPI_library_contents

    @arash77
    arash77 authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7f039d9 View commit details
    Browse the repository at this point in the history

  3. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    52ff504 View commit details
    Browse the repository at this point in the history

  4. Remove old library_contents API route configurations

    @arash77
    arash77 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    331bee7 View commit details
    Browse the repository at this point in the history

  5. make the review process easy

    @arash77
    arash77 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e10fd62 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Refactor library content routes and controllers

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7a57443 View commit details
    Browse the repository at this point in the history

  2. remove unused imports

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5591a8a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'galaxyproject:dev' into FastAPI_library_contents

    @arash77
    arash77 authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c55e214 View commit details
    Browse the repository at this point in the history

  4. move _create_response function to services

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    73c6ddc View commit details
    Browse the repository at this point in the history

  5. Fix url_builder

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f3e3f6d View commit details
    Browse the repository at this point in the history

  6. Add json=true to library_content api tests

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    eb36c65 View commit details
    Browse the repository at this point in the history

  7. update OpenAPI schema

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    663d99c View commit details
    Browse the repository at this point in the history

  8. Update OpenAPI schema

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d944728 View commit details
    Browse the repository at this point in the history

  9. Reformating populators.py

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e60e2bc View commit details
    Browse the repository at this point in the history

  10. Fix test_libraries erros

    @arash77
    arash77 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5f323a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. add LibraryFolderDatabaseIdField Model for library_id

    @arash77
    arash77 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    912ba9b View commit details
    Browse the repository at this point in the history

  2. Fix schema for uploaded_by being None in show library contents endpoi… 

    …nt caused in test_materialize_library_dataset
    @arash77
    arash77 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5bf8e41 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add function for supporting files in library_contents

    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    49b0796 View commit details
    Browse the repository at this point in the history

  2. remove unused enumerate and files field into LibraryContentsFileCreat… 

    …ePayload
    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b2ff40f View commit details
    Browse the repository at this point in the history

  3. Refactor for better readability

    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3e1cdb0 View commit details
    Browse the repository at this point in the history

  4. send data as json when there is no files on creating new_library_data… 

    …set for tests
    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    52b94a1 View commit details
    Browse the repository at this point in the history

  5. update files to upload_files in create payload

    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e53b4f9 View commit details
    Browse the repository at this point in the history

  6. remove unused import

    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d458015 View commit details
    Browse the repository at this point in the history

  7. send none files library_contents create in population with json

    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2a5790d View commit details
    Browse the repository at this point in the history

  8. Apply suggestions: s/title/description in schema, don't do try/except… 

    … in delete logic, rename type aliases for consistency
    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    20bd8fb View commit details
    Browse the repository at this point in the history

  9. remove unused import

    @arash77
    arash77 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2a3d90e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Add tests for library contents API

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d4e7f5d View commit details
    Browse the repository at this point in the history

  2. Deleting and updating not possible for folders! 

    Updating test_update.
    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a4118e4 View commit details
    Browse the repository at this point in the history

  3. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e5beafe View commit details
    Browse the repository at this point in the history

  4. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    adb0b2d View commit details
    Browse the repository at this point in the history

  5. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3a4ee6c View commit details
    Browse the repository at this point in the history

  6. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f8e2f24 View commit details
    Browse the repository at this point in the history

  7. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    156ede6 View commit details
    Browse the repository at this point in the history

  8. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b80f249 View commit details
    Browse the repository at this point in the history

  9. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4dee8ed View commit details
    Browse the repository at this point in the history

  10. Remove old library_contents API route configurations

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b90179d View commit details
    Browse the repository at this point in the history

  11. make the review process easy

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0c6837d View commit details
    Browse the repository at this point in the history

  12. Refactor library content routes and controllers

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fdcc850 View commit details
    Browse the repository at this point in the history

  13. remove unused imports

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f423125 View commit details
    Browse the repository at this point in the history

  14. move _create_response function to services

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3d41893 View commit details
    Browse the repository at this point in the history

  15. Fix url_builder

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4cf20ed View commit details
    Browse the repository at this point in the history

  16. Add json=true to library_content api tests

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4873336 View commit details
    Browse the repository at this point in the history

  17. update OpenAPI schema

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3995e6e View commit details
    Browse the repository at this point in the history

  18. Update OpenAPI schema

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f3670d9 View commit details
    Browse the repository at this point in the history

  19. Reformating populators.py

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    75c6489 View commit details
    Browse the repository at this point in the history

  20. Fix test_libraries erros

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a9151e9 View commit details
    Browse the repository at this point in the history

  21. add LibraryFolderDatabaseIdField Model for library_id

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    07db06a View commit details
    Browse the repository at this point in the history

  22. Fix schema for uploaded_by being None in show library contents endpoi… 

    …nt caused in test_materialize_library_dataset
    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c0e589b View commit details
    Browse the repository at this point in the history

  23. Add function for supporting files in library_contents

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9e47626 View commit details
    Browse the repository at this point in the history

  24. remove unused enumerate and files field into LibraryContentsFileCreat… 

    …ePayload
    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3e22733 View commit details
    Browse the repository at this point in the history

  25. Refactor for better readability

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6d59a46 View commit details
    Browse the repository at this point in the history

  26. send data as json when there is no files on creating new_library_data… 

    …set for tests
    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d43e6b8 View commit details
    Browse the repository at this point in the history

  27. update files to upload_files in create payload

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4d30692 View commit details
    Browse the repository at this point in the history

  28. remove unused import

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9d0bd72 View commit details
    Browse the repository at this point in the history

  29. send none files library_contents create in population with json

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f4cffb3 View commit details
    Browse the repository at this point in the history

  30. Apply suggestions: s/title/description in schema, don't do try/except… 

    … in delete logic, rename type aliases for consistency
    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0a86966 View commit details
    Browse the repository at this point in the history

  31. remove unused import

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d7c3b81 View commit details
    Browse the repository at this point in the history

  32. update schema

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    89a056e View commit details
    Browse the repository at this point in the history

  33. Merge branch 'LC_test' into FastAPI_library_contents

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8d417fb View commit details
    Browse the repository at this point in the history

  34. schema linting

    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b03ce07 View commit details
    Browse the repository at this point in the history

  35. Using DecodedDatabaseIdField instead of `Union[DecodedDatabaseIdFie… 

    …ld, LibraryFolderDatabaseIdField]` for library_id and fix `_create_dataset_in_folder_in_library` function that is leading to failed tests
    @arash77
    arash77 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    110e467 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Remove log from library_contents 

    Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
    @arash77 @mvdbeek
    arash77 and mvdbeek authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5cac3e9 View commit details
    Browse the repository at this point in the history

  2. move library_contents async part into a dependency

    @arash77
    arash77 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    73ff5c6 View commit details
    Browse the repository at this point in the history

  3. Move upload_file tempfile logic to library_contents service file

    @arash77
    arash77 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ce51300 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'galaxyproject:dev' into FastAPI_library_contents

    @arash77
    arash77 authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    da12168 View commit details
    Browse the repository at this point in the history

  5. Fix python lint

    @arash77
    arash77 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    45feaa3 View commit details
    Browse the repository at this point in the history

  6. Deprecate upload_option in LibraryContentsCreatePayload

    @arash77
    arash77 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    800e96f View commit details
    Browse the repository at this point in the history