Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix data_column ref to nested collection #18875

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 23, 2024

Fixes ref to dataset collection elements and refs to HistoryDatasetCollectionAssociation elements that aren't populated yet.
We should have probably excluded inputs that aren't populated yet in the jobs ready to run query

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek
Copy link
Member Author

mvdbeek commented Sep 23, 2024

OK, we should probably improve the jobs ready to run query, but that's a different thing

@mvdbeek mvdbeek marked this pull request as ready for review September 23, 2024 17:24
@github-actions github-actions bot added this to the 24.1 milestone Sep 23, 2024
@mvdbeek mvdbeek requested a review from a team September 24, 2024 07:02
@jmchilton jmchilton merged commit 0c711df into galaxyproject:release_24.1 Sep 24, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants