Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable extra user preferences for remotely authorized users #18887

Merged

Conversation

maartenschermer
Copy link
Contributor

@maartenschermer maartenschermer commented Sep 25, 2024

These changes enable editing of extra user preferences (if enabled in Galaxy conf) for users that are authorized remotely (use_remote_user: true). In the current version, when authorized remotely, the extra user preferences interface in the webapp is automatically disabled together with the editing of email address and username. This PR enables the editing of the extra user preferences, while still disabling editing email and username.

Fixes #18823

Files changed:

  • front-end: UserPreferencesModel.js (to make the 'Manage information' link appear when authorized remotely)
  • middleware: remoteuser.py (added the user/information URL to allowed paths)
  • API: users.py (to disable email/username when authorized remotely)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Set use_remote_user: true in Galaxy conf and implement remote auth (for instance by injecting REMOTE_USER in your request headers)
    2. Enable extra user preferences via config/user_preferences_extra_conf.yml and add some preference input for testing.
    3. Restart Galaxy, and test via User > Preferences > Manage information

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon self-requested a review October 4, 2024 15:45
@dometto
Copy link

dometto commented Oct 16, 2024

@dannon can you perhaps let us know a timeline for reviewing this? Is there anything we can do at this stage? The test failures seem unrelated, to do with the iRODS data source, and seem to happen on at least some other PRs as well.

@dannon
Copy link
Member

dannon commented Oct 16, 2024

@dometto Thanks for the ping, apologies for the delay -- I will set up external auth and test this this morning.

Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/ a local remote user setup -- this is working well for me and I can now edit preferences as a remote user. Thanks @maartenschermer, @dometto !

@dannon dannon merged commit 3e15aa0 into galaxyproject:dev Oct 16, 2024
53 of 55 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@dometto
Copy link

dometto commented Oct 22, 2024

Thanks so much @dannon! I see this PR was tagged for the 24.2 milestone. Could you let us know if there is a set or approximiate release date for this? That will help us determine whether it is worth it for us to implement this patch locally for the time being.

@dannon
Copy link
Member

dannon commented Oct 22, 2024

Sure -- the next release won't be out for at least a month or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra user preferences not available when using remote users
4 participants