-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable extra user preferences for remotely authorized users #18887
Enable extra user preferences for remotely authorized users #18887
Conversation
@dannon can you perhaps let us know a timeline for reviewing this? Is there anything we can do at this stage? The test failures seem unrelated, to do with the iRODS data source, and seem to happen on at least some other PRs as well. |
@dometto Thanks for the ping, apologies for the delay -- I will set up external auth and test this this morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested w/ a local remote user setup -- this is working well for me and I can now edit preferences as a remote user. Thanks @maartenschermer, @dometto !
This PR was merged without a "kind/" label, please correct. |
Thanks so much @dannon! I see this PR was tagged for the 24.2 milestone. Could you let us know if there is a set or approximiate release date for this? That will help us determine whether it is worth it for us to implement this patch locally for the time being. |
Sure -- the next release won't be out for at least a month or so |
These changes enable editing of extra user preferences (if enabled in Galaxy conf) for users that are authorized remotely (use_remote_user: true). In the current version, when authorized remotely, the extra user preferences interface in the webapp is automatically disabled together with the editing of email address and username. This PR enables the editing of the extra user preferences, while still disabling editing email and username.
Fixes #18823
Files changed:
How to test the changes?
(Select all options that apply)
use_remote_user: true
in Galaxy conf and implement remote auth (for instance by injecting REMOTE_USER in your request headers)config/user_preferences_extra_conf.yml
and add some preference input for testing.License