Raise exception if CompressedFile used on incompatible file #18888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprised (or not actually ...) that mypy didn't catch this.
mvdbeek
added
the
kind/refactoring
natefoo
approved these changes
Sep 25, 2024
nsoranzo
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Surprised (or not actually ...) that mypy didn't catch this.
We have not yet enabled the optional enable_error_code = possibly-undefined in mypy.ini, which should generate an error here.
I tested it and it found 188 errors, but sadly not this one, which seems a bug I'm going to report upstream.
In case anyone is interested, here's the new mypy issue: python/mypy#17837 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprised (or not actually ...) that mypy didn't catch this.
How to test the changes?
(Select all options that apply)
License