Improvements to Planemo test format based on feedback/discussions. #18889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
- Allow class: File and class: Collection on file and collection test descriptions. - Allow collection_type: <type> in collection test descriptions. Implement this. - Update test workflows to reflect these two things as best practices.
jmchilton
force-pushed
the
collection_type_check
branch
from
bf223b2
to
389f398
Compare
bgruening
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class: Fileandclass: Collectionon file and collection test descriptions.collection_type: <type>in collection test descriptions. Implement Pydantic validator for these parameters. Implement this check in the verification code (by rewriting it into the attributes dict).How to test the changes?
(Select all options that apply)
License