Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BioBlend tests #18975

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Add BioBlend tests #18975

merged 7 commits into from
Oct 11, 2024
+80 −0

Conversation

arash77
Copy link
Collaborator

@arash77 arash77 commented Oct 10, 2024 •
edited by nsoranzo
Loading

This pull request adds BioBlend tests to the project.
https://github.com/galaxyproject/bioblend/blob/main/.github/workflows/test.yaml

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo self-assigned this Oct 10, 2024
nsoranzo
nsoranzo reviewed Oct 10, 2024
View reviewed changes
.github/workflows/bioblend.yaml Outdated Show resolved Hide resolved
.github/workflows/bioblend.yaml Outdated Show resolved Hide resolved
.github/workflows/bioblend.yaml Outdated Show resolved Hide resolved
.github/workflows/bioblend.yaml Outdated Show resolved Hide resolved
.github/workflows/bioblend.yaml Outdated Show resolved Hide resolved
@arash77 @nsoranzo
Apply suggestions
ece4b67 
Drop galaxy_version and os from matrix and use galaxy_python_version.
Use actions/checkout instead of git clone.

Co-authored-by: Nicola Soranzo <nicola.soranzo@earlham.ac.uk>
@arash77
Copy link
Collaborator Author

arash77 commented Oct 10, 2024 •
edited
Loading

Thank you for the suggestions @nsoranzo

@arash77 arash77 marked this pull request as ready for review October 10, 2024 15:46
@arash77 @nsoranzo
No need to test BioBlend's interactions with the Test ToolShed.
95e6d4c 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@github-actions github-actions bot added this to the 24.2 milestone Oct 10, 2024
nsoranzo
nsoranzo approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 BioBlend tests fail as expected, thanks!
I'd say we merge this and make the tests pass again in a separate PR.

.github/workflows/bioblend.yaml Outdated Show resolved Hide resolved
@arash77 @nsoranzo
virtualenv was only needed by old Galaxy versions.
17cfc6d 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@nsoranzo nsoranzo merged commit 6dc681d into galaxyproject:dev Oct 11, 2024
49 of 52 checks passed
@nsoranzo
Copy link
Member

Thanks @arash77 !

@galaxyproject galaxyproject deleted a comment from github-actions bot Oct 11, 2024
@arash77 arash77 deleted the bioblend_tests branch October 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees

@nsoranzo nsoranzo

Labels
area/testing/api kind/enhancement
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@arash77 @nsoranzo