Irods ssl connection #19014
Merged
Irods ssl connection #19014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pauldg
commented
Nov 12, 2024
| @@ -172,6 +223,11 @@ def __init__(self, config, config_dict): | |||
| if self.connection_pool_monitor_interval is None: | |||
| _config_dict_error("connection->connection_pool_monitor_interval") | |||
|
|
|||
| logical_dict = config_dict.get("logical") or {} | |||
| self.logical_path = logical_dict.get("path") or f"/{self.zone}/home/{self.username}" | |||
There was a problem hiding this comment.
@mvdbeek I think I did cover backward-compatibility by setting the default for self.logical_path to f"/{self.zone}/home/{self.username}" (previously self.home)
|
Thank you @pauldg ! |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows optional ssl settings and an optional logical path on the remote storage.
This is necessary since our irods provider requires ssl parameters to establish connection.
Additionally, the default logical path was hard coded as
self.home = f"/{self.zone}/home/{self.username}"which is not flexibel and may not always exist on the remote storage.How to test the changes?
(Select all options that apply)
License